All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@parisplace.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Subject: Re: Regression introduced by bfcfaa77bdf0f775263e906015982a608df01c76 (vfs: use 'unsigned long' accesses for dcache name comparison and hashing)
Date: Thu, 22 Mar 2012 20:10:27 +0000	[thread overview]
Message-ID: <20120322201027.GA6589@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CACLa4psVGvymuLGJTV+e=n3mYY2h4=nBhb6FGD_PjjE=xMtZgg@mail.gmail.com>

On Thu, Mar 22, 2012 at 04:03:45PM -0400, Eric Paris wrote:
> Reverting this patch also fixed the spurious ENOENT problems (and
> related boot failures) from SELinux.
> 
> Easy reproducer with SELinux enabled (although might I suggest
> permissive/enforcing=0 since the box can't boot otherwise):
> 
> compute_create system_u:system_r:kernel_t:s0
> system_u:object_r:init_exec_t:s0 process
> 
> If you get back system_u:object_r:init_exec_t:s0 it failed and you'll
> see under strace the ENOENT stat() failure.
> 
> If you get back system_u:object_r:init_t:s0 it means it worked...

Unless I'm misreading that code, the problem should hit on names with
length being a multiple of 8...

  reply	other threads:[~2012-03-22 20:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 18:38 Regression introduced by bfcfaa77bdf0f775263e906015982a608df01c76 (vfs: use 'unsigned long' accesses for dcache name comparison and hashing) Konrad Rzeszutek Wilk
2012-03-22 19:33 ` Eric Paris
2012-03-22 20:03   ` Eric Paris
2012-03-22 20:10     ` Al Viro [this message]
2012-03-22 20:09 ` Al Viro
2012-03-22 20:24   ` Al Viro
2012-03-22 20:36     ` Al Viro
2012-03-22 20:42       ` Linus Torvalds
2012-03-22 21:41       ` Konrad Rzeszutek Wilk
2012-03-22 21:54         ` Linus Torvalds
2012-03-22 21:59           ` Al Viro
2012-03-22 20:38     ` Linus Torvalds
2012-03-22 20:44       ` Al Viro
2012-03-22 20:52         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120322201027.GA6589@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=eparis@parisplace.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.