All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "he, bo" <bo.he@intel.com>
Cc: akpm@linux-foudation.org, mingo@elte.hu, a.p.zijlstra@chello.nl,
	rusty@rustcorp.com.au, william.douglas@intel.com,
	linux-kernel@vger.kernel.org, yanmin_zhang@linux.intel.com
Subject: Re: [PATCH 2/2] enable dumpstack() to printk log level
Date: Fri, 23 Mar 2012 13:22:09 +0100	[thread overview]
Message-ID: <20120323122208.GB13920@gmail.com> (raw)
In-Reply-To: <1332493269.2359.9.camel@hebo>


* he, bo <bo.he@intel.com> wrote:

> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -177,20 +177,29 @@ void show_stack(struct task_struct *task, unsigned long *sp)
>  }
>  
>  /*
> - * The architecture-independent dump_stack generator
> + * The architecture-independent dump_stack_log_lvl generator

I guess it wants to say "architecture-dependent"?

> +	show_trace_log_lvl(NULL, NULL, &stack, bp, log_lvl);
> +}
> +EXPORT_SYMBOL(dump_stack_log_lvl);

this should be a _GPL export.

> +}
> +EXPORT_SYMBOL(dump_stack_log_lvl);

Ditto.

Looks useful otherwise.

Thanks,

	Ingo

  reply	other threads:[~2012-03-23 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1332493027.2359.5.camel@hebo>
2012-03-23  9:01 ` [PATCH 2/2] enable dumpstack() to printk log level he, bo
2012-03-23 12:22   ` Ingo Molnar [this message]
2012-03-26  0:59     ` he, bo
2012-03-26  1:36     ` [PATCH_V2 1/2] fix the bug that printk can't support printk(KERN_LEVEL) he, bo
2012-03-28  3:28       ` Yanmin Zhang
2012-04-06  0:57       ` he, bo
2012-03-26  1:36     ` [PATCH_V2 2/2] enable dumpstack() to printk log level he, bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120323122208.GB13920@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foudation.org \
    --cc=bo.he@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=william.douglas@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.