From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:42611 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751915Ab2CWO5K (ORCPT ); Fri, 23 Mar 2012 10:57:10 -0400 Received: by yhmm54 with SMTP id m54so2786541yhm.19 for ; Fri, 23 Mar 2012 07:57:10 -0700 (PDT) Date: Fri, 23 Mar 2012 07:57:05 -0700 From: Greg KH To: Bhupesh SHARMA Cc: "balbi@ti.com" , "linux-usb@vger.kernel.org" , "laurent.pinchart@ideasonboard.com" , spear-devel , "linux-media@vger.kernel.org" Subject: Re: [PATCH] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine Message-ID: <20120323145705.GC11617@kroah.com> References: <4cead89e45e3e31fccae5bb6fbfb72b2ce1b8cd5.1332391406.git.bhupesh.sharma@st.com> <20120322144056.GG19835@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Mar 23, 2012 at 05:31:19PM +0800, Bhupesh SHARMA wrote: > Hi Felipe, > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Thursday, March 22, 2012 8:11 PM > > To: Bhupesh SHARMA > > Cc: linux-usb@vger.kernel.org; laurent.pinchart@ideasonboard.com; > > spear-devel; linux-media@vger.kernel.org > > Subject: Re: [PATCH] usb: gadget/uvc: Remove non-required locking from > > 'uvc_queue_next_buffer' routine > > > > On Thu, Mar 22, 2012 at 10:20:37AM +0530, Bhupesh Sharma wrote: > > > This patch removes the non-required spinlock acquire/release calls on > > > 'queue_irqlock' from 'uvc_queue_next_buffer' routine. > > > > > > This routine is called from 'video->encode' function (which > > translates to either > > > 'uvc_video_encode_bulk' or 'uvc_video_encode_isoc') in 'uvc_video.c'. > > > As, the 'video->encode' routines are called with 'queue_irqlock' > > already held, > > > so acquiring a 'queue_irqlock' again in 'uvc_queue_next_buffer' > > routine causes > > > a spin lock recursion. > > > > > > Signed-off-by: Bhupesh Sharma > > > Acked-by: Laurent Pinchart > > > --- > > > drivers/usb/gadget/uvc_queue.c | 4 +--- > > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > Please use scripts/get_maintainer.pl to determine who to send this to > > (hint, it's not me...) > > > > Can you please pick this USB webcam gadget/peripheral specific patch > in your tree? You didn't put the patch in your request. Hint, just resend it with the proper information, digging patches out of old email threads is a major pain when you are dealing with the patch load kernel maintainers do. thanks, greg k-h