From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Shaohua Li <shli@kernel.org>
Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org
Subject: Re: [patch]pci: fix a panic in pcie_aspm_init_link_state
Date: Fri, 23 Mar 2012 16:27:48 +0000 [thread overview]
Message-ID: <20120323162747.GA23376@srcf.ucam.org> (raw)
In-Reply-To: <4F6AA586.70403@kernel.org>
On Thu, Mar 22, 2012 at 12:07:34PM +0800, Shaohua Li wrote:
>
> My desktop always painc in pcie_aspm_init_link_state. Looks commit
> 4949be16822e92 causes it. The FADT declaims the system doesn't support ASPM.
> Below patch fixes the painc for me. I'm quite strange we still touch aspm
> registers even aspm_disabled.
If the device gives us ASPM control via _OSC and the FADT indicates that
the system doesn't support ASPM, we want to clear the ASPM state - so we
can't simply disable ASPM in that case. Can you get the actual
backtrace?
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2012-03-23 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 4:07 [patch]pci: fix a panic in pcie_aspm_init_link_state Shaohua Li
2012-03-23 16:27 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323162747.GA23376@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.