From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Mark untiled BLT commands as
 fenced on gen2/3
Date: Fri, 23 Mar 2012 20:03:23 +0100
Message-ID: <20120323190323.GF4087@phenom.ffwll.local>
References: <1332326898-20080-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
	[209.85.212.171])
	by gabe.freedesktop.org (Postfix) with ESMTP id F0159A10B3
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 23 Mar 2012 12:02:38 -0700 (PDT)
Received: by wibhj13 with SMTP id hj13so1755916wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 23 Mar 2012 12:02:38 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1332326898-20080-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, stable@kernel.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 21, 2012 at 10:48:18AM +0000, Chris Wilson wrote:
> The BLT commands on gen2/3 utilize the fence registers and so we cannot
> modify any fences for the object whilst those commands are in flight.
> Currently we marked tiled commands as occupying a fence, but forgot to
> restrict the untiled commands from preventing a fence being assigned
> before they were completed.
> 
> One side-effect is that we ten have to double check that a fence was
> allocated for a fenced buffer during move-to-active.
> 
> Reported-by: Jiri Slaby <jirislaby@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43427
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@kernel.org

I've had a few comments on irc about a preliminary version of this patch,
and Chris addressed them all. So

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Futhermore I've stitched together a little testcase in i-g-t, and it
indeed blows up without this patch. So

Testcase: i-g-t/tests/gem_tiled_after_untiled_blt
Tested-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48