Re: [Qemu-devel] [PATCH] fix '-cpu ?' Segfault

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On Thu, Mar 22, 2012 at 09:28:16AM -0400, Stefan Berger wrote:
> On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
> >Fix stupid copy&paste mistake at commit
> >ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
> >"optarg" on the cpu_list() call.
> >
> >Reported-by: Jiri Denemark<jdenemar@redhat.com>
> >Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> >---
> >  vl.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/vl.c b/vl.c
> >index 112b0e0..0fccf50 100644
> >--- a/vl.c
> >+++ b/vl.c
> >@@ -3196,7 +3196,7 @@ int main(int argc, char **argv, char **envp)
> >      cpudef_init();
> >
> >      if (cpu_model&&  *cpu_model == '?') {
> >-        list_cpus(stdout,&fprintf, optarg);
> >+        list_cpus(stdout,&fprintf, cpu_model);
> >          exit(0);
> >      }
> >
> Does -cpu ? actually work then? I only see the list of cpus when
> using -cpu ?_ for example.

I think this is actually just a shell issue:

mdroth@illuin:~/tmp/empty$ ls
mdroth@illuin:~/tmp/empty$ echo ?
?
mdroth@illuin:~/tmp/empty$ touch a
mdroth@illuin:~/tmp/empty$ echo ?
a
mdroth@illuin:~/tmp/empty$ echo ?_
?_

> 
>    Stefan
> 
>