From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SBBEb-0000ch-FN
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SBBEZ-0006qh-QN
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16220)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1SBBEZ-0006qS-IN
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:15 -0400
Date: Fri, 23 Mar 2012 22:37:04 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120323203704.GM23394@garlic>
References: <1332333220-31420-1-git-send-email-ehabkost@redhat.com>
	<4F6B28F0.9060301@linux.vnet.ibm.com>
	<20120323203148.GC2219@illuin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120323203148.GC2219@illuin>
Subject: Re: [Qemu-devel] [PATCH] fix '-cpu ?' Segfault
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, Stefan Berger <stefanb@linux.vnet.ibm.com>

On Fri, Mar 23, 2012 at 03:31:48PM -0500, Michael Roth wrote:
> On Thu, Mar 22, 2012 at 09:28:16AM -0400, Stefan Berger wrote:
> > On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
> > >Fix stupid copy&paste mistake at commit
> > >ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
> > >"optarg" on the cpu_list() call.
> > >
> > >Reported-by: Jiri Denemark<jdenemar@redhat.com>
> > >Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> > >---
> > >  vl.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/vl.c b/vl.c
> > >index 112b0e0..0fccf50 100644
> > >--- a/vl.c
> > >+++ b/vl.c
> > >@@ -3196,7 +3196,7 @@ int main(int argc, char **argv, char **envp)
> > >      cpudef_init();
> > >
> > >      if (cpu_model&&  *cpu_model == '?') {
> > >-        list_cpus(stdout,&fprintf, optarg);
> > >+        list_cpus(stdout,&fprintf, cpu_model);
> > >          exit(0);
> > >      }
> > >
> > Does -cpu ? actually work then? I only see the list of cpus when
> > using -cpu ?_ for example.

use "-cpu \?"

> 
> I think this is actually just a shell issue:
> 
> mdroth@illuin:~/tmp/empty$ ls
> mdroth@illuin:~/tmp/empty$ echo ?
> ?
> mdroth@illuin:~/tmp/empty$ touch a
> mdroth@illuin:~/tmp/empty$ echo ?
> a
> mdroth@illuin:~/tmp/empty$ echo ?_
> ?_
> 
> > 
> >    Stefan
> > 
> > 
>