From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, dp@opensource.wolfsonmicro.com
Subject: Re: [PATCH] regmap: rbtree: Fix register default look-up in sync
Date: Sat, 24 Mar 2012 00:56:41 +0000 [thread overview]
Message-ID: <20120324005640.GC3190@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1332497097-17846-1-git-send-email-lars@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Fri, Mar 23, 2012 at 11:04:57AM +0100, Lars-Peter Clausen wrote:
> The code currently passes the register offset in the current block to
> regcache_lookup_reg. This works fine as long as there is only one block and with
> base register of 0, but in all other cases it will look-up the default for a
> wrong register, which can cause unnecessary register writes. This patch fixes
> it by passing the actual register number to regcache_lookup_reg.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: <stable@vger.kernel.org>
Good catch - I'm fairly surprised nobody (including me) noticed it over
the couple of kernel releases it's been there. Will apply once we've
got an -rc1.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-24 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 10:04 [PATCH] regmap: rbtree: Fix register default look-up in sync Lars-Peter Clausen
2012-03-24 0:56 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324005640.GC3190@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.