From: Andi Kleen <ak@linux.intel.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, tim.c.chen@linux.intel.com
Subject: Re: [RFC, PATCH] Avoid hot statistics cache line in ext4 extent cache
Date: Fri, 23 Mar 2012 20:13:57 -0700 [thread overview]
Message-ID: <20120324031357.GA5690@tassilo.jf.intel.com> (raw)
In-Reply-To: <A3DE1F37-C0AB-4ACE-8D13-22DC8A21ED3C@dilger.ca>
> The patch only disables the statistics counting, but not the sysfs
> files that will now report bogus statistics. I don't disagree with
> disabling these stats, but if you are disabling the accounting you
> should also comment out the functions in fs/ext4/super.c that are
> printing out these statistics.
Aware of that -- that is why it was just a RFC.
The choice is between per cpu counters or completely removing them.
I would prefer the later.
-Andi
next prev parent reply other threads:[~2012-03-24 3:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 22:17 [RFC, PATCH] Avoid hot statistics cache line in ext4 extent cache Andi Kleen
2012-03-24 1:10 ` Andreas Dilger
2012-03-24 3:13 ` Andi Kleen [this message]
2012-03-26 22:26 ` Vivek Haldar
2012-03-26 23:00 ` Andi Kleen
2012-03-26 23:57 ` Ted Ts'o
2012-04-11 16:59 ` Andi Kleen
2012-04-13 17:42 ` Linus Torvalds
2012-04-13 17:53 ` Tim Chen
2012-04-13 18:08 ` Linus Torvalds
2012-04-13 18:31 ` Tim Chen
2012-04-13 18:33 ` Linus Torvalds
2012-04-13 18:37 ` Ted Ts'o
2012-04-13 18:41 ` Andi Kleen
2012-04-13 18:48 ` Ted Ts'o
2012-04-13 19:01 ` Eric Whitney
2012-04-13 19:26 ` Tim Chen
2012-04-13 19:33 ` Ted Ts'o
2012-04-13 17:57 ` Andi Kleen
2012-04-13 18:06 ` Ted Ts'o
2012-04-13 18:22 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324031357.GA5690@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.