From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: enable gmbus on gen2
Date: Sat, 24 Mar 2012 16:08:44 +0100
Message-ID: <20120324150844.GC7563@phenom.ffwll.local>
References: <1330713510-5265-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id D4EF99E78A
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 24 Mar 2012 08:07:59 -0700 (PDT)
Received: by wgbdr12 with SMTP id dr12so2228913wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 24 Mar 2012 08:07:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1330713510-5265-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

Hi Chris,

Given that you're about the only other gen2 user I know ... can you ack
this patch for inclusion into 3.5?

Thanks, Daniel

On Fri, Mar 02, 2012 at 07:38:30PM +0100, Daniel Vetter wrote:
> With the recent set of gmbus fixes, this seems to work on my i855gm.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_i2c.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
> index 601c86e..8f66397 100644
> --- a/drivers/gpu/drm/i915/intel_i2c.c
> +++ b/drivers/gpu/drm/i915/intel_i2c.c
> @@ -388,10 +388,6 @@ int intel_setup_gmbus(struct drm_device *dev)
>  		bus->reg0 = i | GMBUS_RATE_100KHZ;
>  
>  		bus->has_gpio = intel_gpio_setup(bus, i);
> -
> -		/* XXX force bit banging until GMBUS is fully debugged */
> -		if (bus->has_gpio && IS_GEN2(dev))
> -			bus->force_bit = true;
>  	}
>  
>  	intel_i2c_reset(dev_priv->dev);
> -- 
> 1.7.8.3
> 

-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48