From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: max6639: Convert to dev_pm_ops
Date: Sat, 24 Mar 2012 15:33:11 +0000 [thread overview]
Message-ID: <20120324153311.GA2618@ericsson.com> (raw)
In-Reply-To: <1332447838-30632-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark,
On Thu, Mar 22, 2012 at 04:23:58PM -0400, Mark Brown wrote:
> The I2C specific PM operations have been deprecated and printing a
> warning on boot for over a year now.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
Actually, there is a problem with your patch. With the patch applied,
my nightly builds tell me:
Build: /home/groeck/local/linux-staging:hwmon:2:3
/tmp/linux.6026/drivers/hwmon/max6639.c:599: warning: 'max6639_suspend' defined but not used
/tmp/linux.6026/drivers/hwmon/max6639.c:610: warning: 'max6639_resume' defined but not used
--------------------
This suggests that something is wrong if CONFIG_PM is not set (missing #ifdef around the
suspend/resume functions ? Or is there some better way to do this without #ifdef ?).
I'll back out your patch for now. Please have a look.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-03-24 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 20:23 [lm-sensors] [PATCH] hwmon: max6639: Convert to dev_pm_ops Mark Brown
2012-03-23 2:41 ` Guenter Roeck
2012-03-24 15:33 ` Guenter Roeck [this message]
2012-03-26 15:41 ` Mark Brown
2012-03-26 15:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324153311.GA2618@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.