From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: On patch "device.h: audit and cleanup users in main include dir"
Date: Sun, 25 Mar 2012 12:37:40 +0200 [thread overview]
Message-ID: <20120325123740.7cab722b@stein> (raw)
In-Reply-To: <20120325010513.GC12203@windriver.com>
On Mar 24 Paul Gortmaker wrote:
> [On patch "device.h: audit and cleanup users in main include dir"] On 24/03/2012 (Sat 21:21) Stefan Richter wrote:
[...]
> > struct fw_device and struct fw_unit, defined in include/firewire.h,
> > incorporate struct device.
>
> Hi Stefan,
>
> You are correct. I did read them all and check instances of device, so
> I'm not sure how I misread this file. Did you have a specific build
> that triggered a failure, or you just happened to spot it? I'm guessing
> that it gets device.h by another path and hence won't show up in build
> coverage.
I just saw the commit coming in; there is no build failure. (I should have
test-built before posting.) All files which include linux/firewire.h
evidently include linux/device.h before it.
> If so I'll definitely get it fixed, but I might wait a day or two to see
> if anything else pops up, if it isn't explicitly causing any breakage.
If you don't receive any issues with the rest of your tree-wide commit,
just do nothing and I will add a trivial firewire.h correction myself for
the next merge window.
> > Furthermore, the inline function definitions
> > fw_device,
> > fw_unit,
> > fw_unit_get,
> > fw_unit_put,
> > fw_parent_device
> > all require definitions from linux/device.h.
Correcting myself: Only the the latter three of these use linux/device.h.
--
Stefan Richter
-=====-===-- --== ==--=
http://arcgraph.de/sr/
prev parent reply other threads:[~2012-03-25 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 20:21 On patch "device.h: audit and cleanup users in main include dir" Stefan Richter
2012-03-25 1:05 ` Paul Gortmaker
2012-03-25 10:37 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120325123740.7cab722b@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.