From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] net: fec_mxc: allow use with cache enabled
Date: Mon, 26 Mar 2012 01:57:35 +0200 [thread overview]
Message-ID: <201203260157.35616.marex@denx.de> (raw)
In-Reply-To: <1331740746-7412-1-git-send-email-eric.nelson@boundarydevices.com>
Dear Eric Nelson,
> ensure that transmit and receive buffers are cache-line aligned
> invalidate cache for each packet as received
> update receive buffer descriptors one cache line at a time
> flush cache before transmitting
>
> Original patch by Marek:
> http://lists.denx.de/pipermail/u-boot/2012-February/117695.html
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> V2 addresses some concerns from the ML:
> - Use readl()/writel() instead of mapped data structure
> accesses
> - Wrong comment style
> - &rbd_base[0] == rbd_base
> removed 'volatile' from fec_send().
>
> V3 updates from ML (and Marek):
> consolidated CONFIG_FEC_DATA_ALIGNMENT and CONFIG_FEC_DESC_ALIGNMENT
> added cache flushes after initialization of TBD/RBD
>
> V4 updates from ML
> http://lists.denx.de/pipermail/u-boot/2012-March#120139
> remove tabs after #define/#if/#error
> replace CONFIG_FEC_ALIGN with ARCH_DMA_MINALIGN
>
Acked-by: Marek Vasut <marex@denx.de>
Didn't I ack some previous version? Maybe I even added tested-by to some
previous version ;-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-03-25 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-March/#120139>
2012-03-14 15:59 ` [U-Boot] [PATCH V4] net: fec_mxc: allow use with cache enabled Eric Nelson
2012-03-25 23:57 ` Marek Vasut [this message]
2012-03-26 3:00 ` Eric Nelson
2012-03-25 22:11 Eric Nelson
2012-03-25 22:44 ` Marek Vasut
2012-03-25 23:32 ` Eric Nelson
2012-03-26 8:30 ` Stefano Babic
2012-03-26 10:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203260157.35616.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.