From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp
 bridge!
Date: Mon, 26 Mar 2012 11:03:51 +0200
Message-ID: <20120326090351.GE4014@phenom.ffwll.local>
References: <1332747942-2143-1-git-send-email-daniel.vetter@ffwll.ch>
	<1332747942-2143-2-git-send-email-daniel.vetter@ffwll.ch>
	<1332751786_97030@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id 3D5889EB5D
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 26 Mar 2012 02:03:08 -0700 (PDT)
Received: by wgbdr12 with SMTP id dr12so2916352wgb.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 26 Mar 2012 02:03:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1332751786_97030@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Mar 26, 2012 at 09:49:36AM +0100, Chris Wilson wrote:
> On Mon, 26 Mar 2012 09:45:41 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > So don't call it like that.
> > 
> > Also rip out a confusing comment and instead explain what's really
> > going on.
> > 
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > +/*
> > + * This is really ugly: Because old userspace abused the linux agp interface to
> > + * manage the gtt, we need to claim that all intel devices are agp.  For
> > + * otherwise the drm core refuses to initialize the agp support code.
> >   */
> 
> So no new device entries, right?

I plan to merge hsw and vlv support with the current intel-gtt mess and
clean up afterwards. This way there should be less risk that Jesse fumbles
a rebase ;-)

Cheers, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48