From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: max6639: Fix CONFIG_PM compile option
Date: Mon, 26 Mar 2012 10:37:12 +0000 [thread overview]
Message-ID: <20120326103711.GE3098@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1332614169-30854-1-git-send-email-stigge@antcom.de>
[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]
On Sat, Mar 24, 2012 at 03:52:38PM -0700, Guenter Roeck wrote:
> On Sat, Mar 24, 2012 at 03:45:43PM -0400, Roland Stigge wrote:
> > >> +#ifdef CONFIG_PM
> > > Looking into other drivers, I think that should be CONFIG_PM_SLEEP
> > Which other drivers did you mean?
> > What about those drivers that all handle it via CONFIG_PM:
> > abituguru.c
> > abituguru3.c
> > exynos4_tmu.c
> > gpio-fan.c
> > jc42.c
> > lm75.c
> > tmp102.c
> Those drivers don't use SET_SYSTEM_SLEEP_PM_OPS. I checked several drivers
> which do use SET_SYSTEM_SLEEP_PM_OPS, and they all use CONFIG_PM_SLEEP.
It's nothing to do with SET_SYSTEM_SLEEP_PM_OPS - it's more about
drivers that are following current best practice (which includes using
the SET_ macros). A modern driver should be using CONFIG_PM_SLEEP for
system sleep operations and CONFIG_PM_RUNTIME for runtime PM operations
since they can be enabled independently. CONFIG_PM should only control
having dev_pm_ops at all (if you want to bother with the ifdefery).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2012-03-26 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-24 18:36 [lm-sensors] [PATCH] hwmon: max6639: Fix CONFIG_PM compile option Roland Stigge
2012-03-24 19:12 ` Guenter Roeck
2012-03-24 19:45 ` Roland Stigge
2012-03-24 22:52 ` Guenter Roeck
2012-03-26 10:37 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326103711.GE3098@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.