From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755762Ab2CZUNI (ORCPT ); Mon, 26 Mar 2012 16:13:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33445 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755320Ab2CZUNF (ORCPT ); Mon, 26 Mar 2012 16:13:05 -0400 Date: Mon, 26 Mar 2012 13:13:04 -0700 From: Andrew Morton To: Denys Vlasenko Cc: linux-kernel@vger.kernel.org, Douglas W Jones , Michal Nazarewicz Subject: Re: [PATCH 1/1] vsprintf: optimize decimal conversion (again) Message-Id: <20120326131304.018a5f4b.akpm@linux-foundation.org> In-Reply-To: References: <201203262047.17865.vda.linux@googlemail.com> <201203262051.24271.vda.linux@googlemail.com> <20120326125129.78975baf.akpm@linux-foundation.org> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Mar 2012 21:56:38 +0200 Denys Vlasenko wrote: > >> +#if BITS_PER_LONG != 32 || (~(0ULL)>>1) != ((1ULL<<63)-1) > > > > What's this for? > > The second check should be just BITS_PER_LONG_LONG != 64, > but we don't have BITS_PER_LONG_LONG. So let's add BITS_PER_LONG_LONG rather than hacking around its absence!