From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Brad Smith <brad@comstyle.com>
Subject: Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
Date: Mon, 26 Mar 2012 09:53:27 -0500 [thread overview]
Message-ID: <20120326145327.GA2884@illuin> (raw)
In-Reply-To: <4F7036A1.8070107@redhat.com>
On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
> On 25.03.2012 03:19, Brad Smith wrote:
> > On 20/03/12 9:28 AM, Brad Smith wrote:
> >> On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>> On 18.03.2012 02:09, Brad Smith wrote:
> >>>> Michal,
> >>>>
> >>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> This broke the build. Un-break the tree.
> >>>>
> >>>
> >>>
> >>> Can you please be more specific? It works for me so I don't have a clue
> >>> what are you referring to. I mean, what compiler do you use, what errors
> >>> are thrown, etc.
> >>>
> >>> Michal
> >>
> >> The patch commited is full of Linux specific code.
> >
> > This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> > then REVERT
> > the broken commit.
> >
>
> Brad,
>
> that's because the fix hasn't been merged yet. If you need fix very
> quickly you can apply this patch:
>
> http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
That one also requires your previous patch, and misses some things Luiz
caught. This is the latest one, Brad is CC'd:
http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html
>
> Michal
>
next prev parent reply other threads:[~2012-03-26 14:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 1:09 [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command Brad Smith
2012-03-20 10:14 ` Michal Privoznik
2012-03-20 13:28 ` Brad Smith
2012-03-25 1:19 ` Brad Smith
2012-03-25 19:47 ` Michael Roth
2012-03-26 9:28 ` Michal Privoznik
2012-03-26 14:53 ` Michael Roth [this message]
2012-03-26 14:55 ` Anthony Liguori
2012-03-26 15:15 ` Michael Roth
2012-03-26 15:18 ` Anthony Liguori
2012-03-26 15:20 ` Michal Privoznik
2012-03-26 17:07 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326145327.GA2884@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=brad@comstyle.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.