From: Ted Ts'o <tytso@mit.edu>
To: Sami Liedes <sami.liedes@iki.fi>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 5/5] libext2fs: Implement fast find_first_zero() for bitarray bitmaps.
Date: Mon, 26 Mar 2012 11:26:07 -0400 [thread overview]
Message-ID: <20120326152607.GB15027@thunk.org> (raw)
In-Reply-To: <20120326132258.GA31953@cc.hut.fi>
On Mon, Mar 26, 2012 at 04:22:58PM +0300, Sami Liedes wrote:
> Hmm, no, I don't think so? count==0 here iff we have tested as many
> bits as the caller requested. So this code will bail out if the number
> of bits to test is not large enough to even hit a byte boundary, or if
> the last bit to test and the byte boundary coincide. Perhaps count
> should be renamed to something like bits_left_to_test if it's
> confusing now?
Ah, you're right, my bad. I managed to confuse myself with !count.
In cases where we're not dealing with a boolean value, it's actually
better to write (count == 0), for this reason.
> I agree that a regression test is needed. I'll look into writing that.
If you could work on improving tst_bitmaps, that would be great. Thanks!!
- Ted
prev parent reply other threads:[~2012-03-26 15:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 21:33 [PATCH 0/5] Make filesystem shrinking faster and less CPU-intensive Sami Liedes
2012-03-10 21:34 ` [PATCH 1/5] libext2fs: Move a modulo operation out of a hot loop Sami Liedes
2012-03-11 9:50 ` Andreas Dilger
2012-03-10 21:35 ` [PATCH 2/5] resize2fs: Use EXT2_FLAG_64BITS Sami Liedes
2012-03-10 21:36 ` [PATCH 3/5] libext2fs: Document EXT2_FLAG_64BITS in ext2fs_open2() Sami Liedes
2012-03-10 21:37 ` [PATCH 4/5] libext2fs: Implement ext2fs_find_first_zero_generic_bmap() Sami Liedes
2012-03-11 9:51 ` Andreas Dilger
2012-03-12 19:15 ` Sami Liedes
2012-03-12 23:09 ` Andreas Dilger
2012-03-23 22:33 ` Ted Ts'o
2012-03-26 13:53 ` Sami Liedes
2012-03-26 15:34 ` Ted Ts'o
2012-03-26 2:39 ` Ted Ts'o
2012-03-10 21:38 ` [PATCH 5/5] libext2fs: Implement fast find_first_zero() for bitarray bitmaps Sami Liedes
2012-03-26 2:34 ` Ted Ts'o
2012-03-26 13:22 ` Sami Liedes
2012-03-26 15:26 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326152607.GB15027@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sami.liedes@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.