From: Joe Thornber <thornber@redhat.com>
To: device-mapper development <dm-devel@redhat.com>,
Alasdair G Kergon <agk@redhat.com>, Joe Thornber <ejt@redhat.com>
Subject: Re: [PATCH] dm thin: fix pool target flags that control discard
Date: Mon, 26 Mar 2012 16:46:26 +0100 [thread overview]
Message-ID: <20120326154625.GB26558@ubuntu> (raw)
In-Reply-To: <20120326141520.GA24249@ubuntu>
commit 1f04d92a1dd6173e38d7dc652dfe22876c40957e
Author: Joe Thornber <ejt@redhat.com>
Date: Mon Mar 26 16:43:36 2012 +0100
dm-thin: don't set ti->discards_supported for the pool target
The pool is little more than a linear target; the default dm decision
about whether to support discards is adequate.
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index e5a6ed4..015cdce 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -1646,10 +1646,8 @@ static int pool_ctr(struct dm_target *ti, unsigned argc, char **argv)
pt->low_water_blocks = low_water_blocks;
pt->pf = pf;
ti->num_flush_requests = 1;
- if (pf.discard_enabled && pf.discard_passdown) {
- ti->discards_supported = 1;
+ if (pf.discard_enabled && pf.discard_passdown)
ti->num_discard_requests = 1;
- }
ti->private = pt;
pt->callbacks.congested_fn = pool_is_congested;
next prev parent reply other threads:[~2012-03-26 15:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 15:21 dm-thin patches for 3.4 Joe Thornber
2012-03-16 15:22 ` [PATCH 01/14] dm-thin: don't use the bi_next field for the holder of a cell Joe Thornber
2012-03-16 15:22 ` [PATCH 02/14] dm-thin: remove some documentation for the unimplemented 'trim' target message Joe Thornber
2012-03-16 15:22 ` [PATCH 03/14] dm_thin: dm_sm_root_size() was being called for the wrong space-map Joe Thornber
2012-03-16 15:22 ` [PATCH 04/14] dm_thin: tweak a comment Joe Thornber
2012-03-16 15:22 ` [PATCH 05/14] dm_btree: remove redundant arg from value_ptr() Joe Thornber
2012-03-16 15:22 ` [PATCH 06/14] dm_btree: fix rebalancing of 3 nodes after remove Joe Thornber
2012-03-16 15:22 ` [PATCH 07/14] dm_space_map: remove entries from the ref_count tree if they're no longer needed Joe Thornber
2012-03-16 15:22 ` [PATCH 08/14] dm_thin: add support for read-only external snapshot origins Joe Thornber
2012-03-16 15:22 ` [PATCH 09/14] dm_thin: foundation for discard support Joe Thornber
2012-03-16 15:22 ` [PATCH 10/14] dm_thin: add support for REQ_DISCARD Joe Thornber
2012-03-23 12:45 ` Alasdair G Kergon
2012-03-16 15:22 ` [PATCH 11/14] dm_thin: add pool target flags to control discard Joe Thornber
2012-03-23 12:37 ` Alasdair G Kergon
2012-03-23 21:55 ` [PATCH] dm thin: fix pool target flags that " Mike Snitzer
2012-03-26 14:15 ` Joe Thornber
2012-03-26 15:33 ` Mike Snitzer
2012-03-26 19:56 ` Mike Snitzer
2012-03-26 15:34 ` [PATCH] " Joe Thornber
2012-03-26 15:46 ` Joe Thornber [this message]
2012-03-16 15:22 ` [PATCH 12/14] dm_thin: commit metadata every second Joe Thornber
2012-03-16 15:22 ` [PATCH 13/14] dm_thin: commit just before processing a pool target info request Joe Thornber
2012-03-19 14:00 ` Alasdair G Kergon
2012-03-20 10:12 ` Joe Thornber
2012-03-16 15:22 ` [PATCH 14/14] dm_thin: bump the target versions Joe Thornber
2012-03-20 18:24 ` [PATCH 01/14] dm-thin: don't use the bi_next field for the holder of a cell Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326154625.GB26558@ubuntu \
--to=thornber@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.