All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Julian Calaby <julian.calaby@gmail.com>, <zajec5@gmail.com>,
	<linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device
Date: Mon, 26 Mar 2012 14:56:42 -0400	[thread overview]
Message-ID: <20120326185641.GA22375@windriver.com> (raw)
In-Reply-To: <4F70543F.2010007@hauke-m.de>

The following is seen during allmodconfig builds for MIPS:

drivers/bcma/driver_pci_host.c:518:2: error: implicit declaration
of function 'pcibios_enable_device' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/bcma/driver_pci_host.o] Error 1

Most likey introduced by commit 49dc9577155576b10ff79f0c1486c816b01f58bf

   "bcma: add PCIe host controller"

Add the header instead of implicitly assuming it will be present.
Sounds like a good idea, but that alone doesn't fix anything.

The real problem is that the Kconfig has settings related to whether
PCI is possible, i.e.

 config BCMA_HOST_PCI_POSSIBLE
       bool
       depends on BCMA && PCI = y
       default y

 config BCMA_HOST_PCI
       bool "Support for BCMA on PCI-host bus"
       depends on BCMA_HOST_PCI_POSSIBLE

...but what is missing is that BCMA_DRIVER_PCI_HOSTMODE doesn't
have any dependencies on the above.  Add one.

CC: Hauke Mehrtens <hauke@hauke-m.de>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[ v2: depend on BCMA_HOST_PCI_POSSIBLE, not BCMA_HOST_PCI ]

diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig
index c1172da..6a0082d 100644
--- a/drivers/bcma/Kconfig
+++ b/drivers/bcma/Kconfig
@@ -29,7 +29,7 @@ config BCMA_HOST_PCI
 
 config BCMA_DRIVER_PCI_HOSTMODE
 	bool "Driver for PCI core working in hostmode"
-	depends on BCMA && MIPS
+	depends on BCMA && MIPS && BCMA_HOST_PCI_POSSIBLE
 	help
 	  PCI core hostmode operation (external PCI bus).
 
diff --git a/drivers/bcma/driver_pci_host.c b/drivers/bcma/driver_pci_host.c
index 4e20bcf..d2097a1 100644
--- a/drivers/bcma/driver_pci_host.c
+++ b/drivers/bcma/driver_pci_host.c
@@ -10,6 +10,7 @@
  */
 
 #include "bcma_private.h"
+#include <linux/pci.h>
 #include <linux/export.h>
 #include <linux/bcma/bcma.h>
 #include <asm/paccess.h>
-- 
1.7.9.1

  reply	other threads:[~2012-03-26 18:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26  0:02 [PATCH] bcma: fix build error on MIPS; implicit pcibios_enable_device Paul Gortmaker
2012-03-26  0:13 ` Julian Calaby
2012-03-26  1:20   ` Paul Gortmaker
2012-03-26  1:28     ` Julian Calaby
2012-03-26 11:34       ` Hauke Mehrtens
2012-03-26 18:56         ` Paul Gortmaker [this message]
2012-03-27 10:53           ` Hauke Mehrtens
2012-03-27 19:27             ` Paul Gortmaker
2012-03-26 11:30 ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120326185641.GA22375@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=hauke@hauke-m.de \
    --cc=julian.calaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.