All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
	Alex Elder <elder@kernel.org>,
	stable@kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs: Fix oops on IO error during xlog_recover_process_iunlinks()
Date: Mon, 26 Mar 2012 16:56:01 -0500	[thread overview]
Message-ID: <20120326215601.GY7762@sgi.com> (raw)
In-Reply-To: <1331804042-11580-1-git-send-email-jack@suse.cz>

On Thu, Mar 15, 2012 at 10:34:02AM +0100, Jan Kara wrote:
> When an IO error happens during inode deletion run from
> xlog_recover_process_iunlinks() filesystem gets shutdown. Thus any subsequent
> attempt to read buffers fails. Code in xlog_recover_process_iunlinks() does not
> count with the fact that read of a buffer which was read a while ago can
> really fail which results in the oops on
>   agi = XFS_BUF_TO_AGI(agibp);
> 
> Fix the problem by cleaning up the buffer handling in
> xlog_recover_process_iunlinks() as suggested by Dave Chinner. We release buffer
> lock but keep buffer reference to AG buffer. That is enough for buffer to stay
> pinned in memory and we don't have to call xfs_read_agi() all the time.
> 
> CC: stable@kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>

Looks good to me...
Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-03-26 21:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  9:34 [PATCH v3] xfs: Fix oops on IO error during xlog_recover_process_iunlinks() Jan Kara
2012-03-26 21:56 ` Ben Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120326215601.GY7762@sgi.com \
    --to=bpm@sgi.com \
    --cc=elder@kernel.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=stable@kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.