From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU Date: Tue, 27 Mar 2012 13:17:19 +0200 Message-ID: <20120327111719.GI4276@phenom.ffwll.local> References: <1332749427-2729-1-git-send-email-daniel.vetter@ffwll.ch> <1332750777_96879@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DD6F9E8F3 for ; Tue, 27 Mar 2012 04:16:35 -0700 (PDT) Received: by wibhj13 with SMTP id hj13so3955608wib.12 for ; Tue, 27 Mar 2012 04:16:35 -0700 (PDT) In-Reply-To: <1332750777_96879@CP5-2952> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 26, 2012 at 09:32:52AM +0100, Chris Wilson wrote: > On Mon, 26 Mar 2012 10:10:27 +0200, Daniel Vetter wrote: > > From: Chris Wilson > > > > We try to avoid writing the relocations through the uncached GTT, if the > > buffer is currently in the CPU write domain and so will be flushed out to > > main memory afterwards anyway. Also on SandyBridge we can safely write > > to the pages in cacheable memory, so long as the buffer is LLC mapped. > > In either of these caches, we therefore do not need to force the > s/caches/cases/ > > > reallocation of the buffer into the mappable region of the GTT, reducing > > the aperture pressure. Applied to dinq with the spelling fixed. Thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48