From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC PATCH BlueZ] event: Remove unused dev_class parameter from btd_event_conn_complete()
Date: Tue, 27 Mar 2012 14:55:30 +0300 [thread overview]
Message-ID: <20120327115530.GJ14481@x220> (raw)
In-Reply-To: <1332782979-27081-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Lizardo,
On Mon, Mar 26, 2012, Anderson Lizardo wrote:
> This parameter is not being used by hciops nor mgmtops.
> ---
> plugins/hciops.c | 5 ++---
> plugins/mgmtops.c | 3 +--
> src/event.c | 2 +-
> src/event.h | 2 +-
> 4 files changed, 5 insertions(+), 7 deletions(-)
The right fix is to make use of this parameter instead of removing it.
If btd_device has a variable for it, it should be updated and we should
also write it to storage.
Johan
next prev parent reply other threads:[~2012-03-27 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 17:29 [RFC PATCH BlueZ] event: Remove unused dev_class parameter from btd_event_conn_complete() Anderson Lizardo
2012-03-27 11:55 ` Johan Hedberg [this message]
2012-03-27 12:17 ` Anderson Lizardo
2012-03-27 12:45 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327115530.GJ14481@x220 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.