From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] floppy: revert floppy disable halt warning
Date: Tue, 27 Mar 2012 16:26:33 -0700 [thread overview]
Message-ID: <20120327162633.654c8d7e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120311093853.04f049c2@s6510.linuxnetplumber.net>
(cc some x86 greybeards)
On Sun, 11 Mar 2012 09:38:53 -0700
Stephen Hemminger <shemminger@vyatta.com> wrote:
> Remove the stupid floppy disable halt warning. It is meaningless since
> the API is local to floppy driver. Our boot scripts check for the
> floppy drive, and this causes the warning to trigger every time. This
> confuses support, breaks automated tests that look for backtraces on
> boot, and adds no value.
>
> The message is being displayed to the wrong audience, it looks like it
> was intended as a compromise of a long discussion on LKML about
> supporting older x86 hardware; but users don't know or understand what
> it is saying.
>
> If you want to change halt handling then just fix
> the floppy driver, don't whine about it.
>
> ...
>
> --- a/drivers/block/floppy.c 2012-03-11 09:27:52.866459327 -0700
> +++ b/drivers/block/floppy.c 2012-03-11 09:28:29.286579201 -0700
> @@ -1037,7 +1037,6 @@ static void floppy_disable_hlt(void)
> {
> unsigned long flags;
>
> - WARN_ONCE(1, "floppy_disable_hlt() scheduled for removal in 2012");
> spin_lock_irqsave(&floppy_hlt_lock, flags);
> if (!hlt_disabled) {
> hlt_disabled = 1;
It would have been nice to have provided a pointer to this "long
discussion on LKML". I tried for a while, then gave up.
In my search I came across
http://lkml.indiana.edu/hypermail/linux/kernel/1104.0/00461.html which
does indeed remove all the disable_hlt() code as well as the warning
and the feature-removal-schedule.txt record. Why didn't we merge that?
Why shouldn't we merge that now?
next prev parent reply other threads:[~2012-03-27 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 16:38 [PATCH] floppy: revert floppy disable halt warning Stephen Hemminger
2012-03-27 23:26 ` Andrew Morton [this message]
2012-03-28 0:24 ` Josh Boyer
2012-03-28 6:40 ` Ingo Molnar
2012-03-28 7:20 ` H. Peter Anvin
2012-03-28 7:34 ` Ingo Molnar
2012-03-28 10:46 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327162633.654c8d7e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.