From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bojan Smojver <bojan@rexursive.com>
Cc: linux-kernel@vger.kernel.org,
Linux PM mailing list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering
Date: Wed, 28 Mar 2012 00:47:33 +0200 [thread overview]
Message-ID: <201203280047.33501.rjw@sisk.pl> (raw)
In-Reply-To: <1332887999.2040.13.camel@shrek.rexursive.com>
On Wednesday, March 28, 2012, Bojan Smojver wrote:
> On Wed, 2012-03-28 at 00:41 +0200, Rafael J. Wysocki wrote:
> > If you define a macro, please use capital letters in the name. Also,
> > the parentheses aren't necessary I think.
> >
> > Perhaps it would be better to use a static inline function instead?
>
> Hmm, was just following the nr_free_pages() definition in swap.h:
>
> /* Definition of global_page_state not available yet */
> #define nr_free_pages() global_page_state(NR_FREE_PAGES)
>
> Still no good?
Not really, that should be a static inline too. :-)
Thanks,
Rafael
next prev parent reply other threads:[~2012-03-27 22:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 22:31 [PATCH v5]: Hibernation: lower/better control the amount of pages used for buffering Bojan Smojver
2012-03-27 22:41 ` Rafael J. Wysocki
2012-03-27 22:39 ` Bojan Smojver
2012-03-27 22:47 ` Rafael J. Wysocki [this message]
2012-03-27 22:43 ` Bojan Smojver
2012-03-27 22:54 ` Rafael J. Wysocki
2012-03-27 22:53 ` Bojan Smojver
2012-03-27 23:18 ` Rafael J. Wysocki
2012-03-27 23:29 ` Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203280047.33501.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=bojan@rexursive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.