From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh/next: Fix build fail by asm/system.h in asm/bitops.h
Date: Wed, 28 Mar 2012 04:42:04 +0000 [thread overview]
Message-ID: <20120328044204.GO26543@linux-sh.org> (raw)
In-Reply-To: <1331010429-29574-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Wed, Mar 28, 2012 at 01:41:43PM +0900, Nobuhiro Iwamatsu wrote:
> Guennadi Liakhovetski ????????????????????????:
> >On Fri, 9 Mar 2012, Nobuhiro Iwamatsu wrote:
> >
> >>Paul Mundt ????????????????????????:
> >>>On Tue, Mar 06, 2012 at 02:07:09PM +0900, Nobuhiro Iwamatsu wrote:
> >>>>Other files are not done include definitely by asm/system.h made
> >>>>include in asm/bitops.h.
> >>>>This patch remove asm/system.h from asm/bitops.h.
> >>>>
> >>>Which defconfig were you using that hit this? asm/system.h is usually
> >>>included for a reason, although I can't remember off the top of my head
> >>>what's used out of it and on what CPU configuration, but I would be
> >>>rather hesitant to yank it out on an N of 1 build test.
> >>>
> >>Sorry, I checked sh7785lcr and ap325rxa and other.
> >>We can confirm this problem in linux-next.
> >
> >This breakage is now in the mainline too, please, fix. Paul, if you're
> >concerned about removing asm/system.h, the below diff preserves it in
> >asm/bitops.h, but is much uglier, so, I hope the original patch gets
> >applied.
>
> Tested-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Ok, it seems to hold up for random builds and all of the configurations I
tested, so perhaps whatever reason we needed the header there for in the
first place went away some time ago and I never noticed.
I've applied the original now, thanks.
prev parent reply other threads:[~2012-03-28 4:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 5:07 [PATCH] sh/next: Fix build fail by asm/system.h in asm/bitops.h Nobuhiro Iwamatsu
2012-03-07 6:36 ` Paul Mundt
2012-03-09 3:16 ` Nobuhiro Iwamatsu
2012-03-23 8:05 ` Guennadi Liakhovetski
2012-03-28 4:41 ` Nobuhiro Iwamatsu
2012-03-28 4:42 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328044204.GO26543@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.