From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/06] ARM: mach-shmobile: Rework sh7372 INTCS demuxer
Date: Wed, 28 Mar 2012 07:05:48 +0000 [thread overview]
Message-ID: <20120328070548.GV26543@linux-sh.org> (raw)
In-Reply-To: <20120328064105.28557.57736.sendpatchset@w520>
On Wed, Mar 28, 2012 at 03:41:05PM +0900, Magnus Damm wrote:
> @@ -554,12 +548,24 @@ static void intcs_demux(unsigned int irq
> generic_handle_irq(intcs_evt2irq(evtcodeas));
> }
>
> +static void intcs_nop(struct irq_data *data)
> +{
> +}
> +
> +static struct irq_chip intcs_cascade_chip = {
> + .name = "INTCS-cascade",
> + .irq_mask = intcs_nop,
> + .irq_unmask = intcs_nop,
> + .irq_eoi = intcs_nop,
> +};
> +
There's no need for this, see kernel/irq/dummychip.c. You can just use
dummy_irq_chip directly, as we already do for the multi-evt cascade case.
next prev parent reply other threads:[~2012-03-28 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:41 [PATCH 06/06] ARM: mach-shmobile: Rework sh7372 INTCS demuxer Magnus Damm
2012-03-28 7:05 ` Paul Mundt [this message]
2012-03-28 10:23 ` [PATCH 06/06] ARM: mach-shmobile: Rework sh7372 INTCS demuxer V2 Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328070548.GV26543@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.