From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCpI2-0006g6-Vk for qemu-devel@nongnu.org; Wed, 28 Mar 2012 05:35:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCpHw-0001ts-G3 for qemu-devel@nongnu.org; Wed, 28 Mar 2012 05:35:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCpHw-0001tl-7a for qemu-devel@nongnu.org; Wed, 28 Mar 2012 05:35:32 -0400 Date: Wed, 28 Mar 2012 11:35:21 +0200 From: Alon Levy Message-ID: <20120328093521.GT32389@garlic> References: <20120326173750.20814.75373.stgit@ginnungagap.bsc.es> <1332866260-28387-1-git-send-email-alevy@redhat.com> <8762dp7wj1.fsf@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <8762dp7wj1.fsf@ginnungagap.bsc.es> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: stefanha@gmail.com, qemu-devel@nongnu.org On Tue, Mar 27, 2012 at 08:01:54PM +0200, Llu=EDs Vilanova wrote: > Alon Levy writes: >=20 > > Signed-off-by: Alon Levy > > --- > > Makefile.objs | 25 ++++++++++++++++++++++--- > > 1 file changed, 22 insertions(+), 3 deletions(-) >=20 > > diff --git a/Makefile.objs b/Makefile.objs > > index 8e56f48..0e33f4b 100644 > > --- a/Makefile.objs > > +++ b/Makefile.objs > > @@ -373,12 +373,25 @@ else > > trace.h: trace.h-timestamp > > endif > > trace.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host= .mak > > - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py --f= ormat=3Dh --backend=3D$(TRACE_BACKEND) < $< > $@," GEN trace.h") > > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \ > > + --format=3Dh \ > > + --backend=3D$(TRACE_BACKEND) \ > > + --binary=3D$(bindir)/$(QEMU_PROG) \ > > + --target-arch=3D$(TARGET_ARCH) \ > > + --target-type=3D$(TARGET_TYPE) \ > > + --target-type=3D$(TARGET_TYPE) < $< > $@, \ > > + " GEN trace.h") > > @cmp -s $@ trace.h || cp $@ trace.h > =20 > > trace.c: trace.c-timestamp > > trace.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host= .mak > > - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py --f= ormat=3Dc --backend=3D$(TRACE_BACKEND) < $< > $@," GEN trace.c") > > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \ > > + --format=3Dc \ > > + --backend=3D$(TRACE_BACKEND) \ > > + --binary=3D$(bindir)/$(QEMU_PROG) \ > > + --target-arch=3D$(TARGET_ARCH) \ > > + --target-type=3D$(TARGET_TYPE) < $< > $@, \ > > + " GEN trace.c") > > @cmp -s $@ trace.c || cp $@ trace.c > =20 > > trace.o: trace.c $(GENERATED_HEADERS) > > @@ -391,7 +404,13 @@ trace-dtrace.h: trace-dtrace.dtrace > > # rule file. So we use '.dtrace' instead > > trace-dtrace.dtrace: trace-dtrace.dtrace-timestamp > > trace-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)= /config-host.mak > > - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py --f= ormat=3Dd --backend=3D$(TRACE_BACKEND) < $< > $@," GEN trace-dtrace.dt= race") > > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \ > > + --format=3Dd \ > > + --backend=3D$(TRACE_BACKEND) \ > > + --binary=3D$(bindir)/$(QEMU_PROG) \ > > + --target-arch=3D$(TARGET_ARCH) \ > > + --target-type=3D$(TARGET_TYPE) < $< > $@, \ > > + " GEN trace-dtrace.dtrace") > > @cmp -s $@ trace-dtrace.dtrace || cp $@ trace-dtrace.dtrace > =20 > > trace-dtrace.o: trace-dtrace.dtrace $(GENERATED_HEADERS) > > --=20 > > 1.7.9.3 >=20 > I don't see the reason for such a change, as in the current bash code i= t's not > used except when generating files in the 'stap' format. Have you tried building with trace backend dtrace? without those changed it breaks because tracetool.py requires both target_arch and target_type for dtrace backend. Either change the source or change the invocation. I thought the later is better, hence this patch. >=20 > Same applies to your change in tracetool.py when checking the binary/pr= obe/etc > options. >=20 >=20 > Lluis >=20 > --=20 > "And it's much the same thing with knowledge, for whenever you learn > something new, the whole world becomes that much richer." > -- The Princess of Pure Reason, as told by Norton Juster in The Phanto= m > Tollbooth