Re: [PATCH] mac80211_hwsim: Report rate info in tx status

[Timo Lindhorst <tlnd@online.de>]

Hey,

> +     if (!ack)
> +             for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> +                     tx_count[i] = txi->control.rates[i].count;
> +
>       ieee80211_tx_info_clear_status(txi);
>       if (!(txi->flags & IEEE80211_TX_CTL_NO_ACK) && ack)
>               txi->flags |= IEEE80211_TX_STAT_ACK;
> +
> +     if (ack) {
> +             txi->status.rates[0].count = 1;
> +             txi->status.rates[1].idx = -1;
> +     } else {
> +             for (i = 0; i < IEEE80211_TX_MAX_RATES; i++)
> +                     txi->control.rates[i].count = tx_count[i];
> +     }
> +
>       ieee80211_tx_status_irqsafe(hw, skb);
>  }

I know: backing up the count values, clearing the status, and restoring the
values if necessary is kind of ugly. Would it be better to partly clear the 
status manually instead of using ieee80211_tx_info_clear_status() ?

Regards
Timo