From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
Gertjan van Wingerde <gwingerde@gmail.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 2/4] rt2x00: move disabling of DMA before loading firmware
Date: Wed, 28 Mar 2012 15:15:44 +0200 [thread overview]
Message-ID: <20120328131543.GD3333@redhat.com> (raw)
In-Reply-To: <CAGRGNgWCDo7GpSOC5H-HE_uiF05wGh7FSQw5HL68XB9f8Xg5nA@mail.gmail.com>
Hi
On Wed, Mar 28, 2012 at 11:58:45PM +1100, Julian Calaby wrote:
> > Hm. I obviously did check whether FW load does overwrite WPDMA_GLO_CFG
> > and it didn't. Maybe it's device dependent? What bothers me is that now
> > we have a (very) short window between FW load and disabling DMA.
>
> Stupid question: why not disable DMA before the FW load, then disable
> it afterwards just to make sure the hardware's in a known state after
> the FW load? - this will catch any errant firmwares out there and
> (mostly) eliminate the window between FW load and DMA disabling.
Yep, that seems to be the best approach.
Stanislaw
next prev parent reply other threads:[~2012-03-28 13:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 14:51 [PATCH 0/4] rt2x00: fix initialization after legacy driver Jakub Kicinski
2012-03-27 14:51 ` [PATCH 1/4] rt2x00: broaden PCIE L1-state wakeup configuration Jakub Kicinski
2012-03-27 18:19 ` Gertjan van Wingerde
2012-03-27 22:52 ` [rt2x00-users] " Jakub Kicinski
2012-03-28 12:38 ` Stanislaw Gruszka
2012-03-27 14:51 ` [PATCH 2/4] rt2x00: move disabling of DMA before loading firmware Jakub Kicinski
2012-03-27 18:11 ` Gertjan van Wingerde
2012-03-28 12:14 ` Stanislaw Gruszka
2012-03-28 12:53 ` [rt2x00-users] " Jakub Kicinski
2012-03-28 12:58 ` Julian Calaby
2012-03-28 13:15 ` Stanislaw Gruszka [this message]
2012-03-27 14:51 ` [PATCH 3/4] rt2x00: initialize queues before giving up due to DMA error Jakub Kicinski
2012-03-27 18:13 ` Gertjan van Wingerde
2012-03-27 14:51 ` [PATCH 4/4] rt2x00: zero registers of unused TX rings Jakub Kicinski
2012-03-27 18:13 ` Gertjan van Wingerde
2012-04-16 9:11 ` [rt2x00-users] [PATCH 0/4] rt2x00: fix initialization after legacy driver Andreas Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328131543.GD3333@redhat.com \
--to=sgruszka@redhat.com \
--cc=gwingerde@gmail.com \
--cc=julian.calaby@gmail.com \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.