From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCsk3-0007Jl-Dq for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:16:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCsk1-0005dQ-4r for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:16:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCsk0-0005dC-TD for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:16:45 -0400 Date: Wed, 28 Mar 2012 15:16:34 +0200 From: Alon Levy Message-ID: <20120328131634.GY32389@garlic> References: <1332921337-14785-1-git-send-email-alevy@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?iso-8859-1?Q?Llu=EDs?= Vilanova , stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote: > On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy wrote: > > --- > > =A0trace-events | =A0 =A04 ++-- > > =A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > We're always going to struggle with new trace events that add reserved > keywords. Fixing up trace-events is going to be an ongoing task so > I'd like to also see tracetool automatically modify keywords 'next' -> > 'next_'. Do you want to send a patch to do that instead? sure. For the new tracetool.py too ? :) >=20 > Stefan >=20