From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, James Pickens <jepicken@gmail.com>,
Git ML <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] git: continue alias lookup on EACCES errors
Date: Wed, 28 Mar 2012 13:40:14 -0500 [thread overview]
Message-ID: <20120328184014.GA8982@burratino> (raw)
In-Reply-To: <7v1uocwpap.fsf@alter.siamese.dyndns.org>
On Wed, Mar 28, 2012 at 11:31:10AM -0700, Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> Example: when I try
>>
>> :; mkdir $HOME/cannotread
>> :; chmod -x $HOME/cannotread
>> :; echo nonsense >$HOME/bin/cat
>> :; chmod -x $HOME/bin/cat
>> :; PATH=$HOME/cannotread:$HOME/bin:/usr/local/bin:/usr/bin:/bin
>> :; cat /etc/fstab
>>
>> the shell uses /bin/cat without complaint.
>
> Yeah, but I think that the case Peff is worried about is:
>
> $ >~/bin/nosuch
> $ nosuch
> nosuch: Permission denied
Just remembering the EACCES and reporting it when no alias exists
would take care of that, no? In other words, this seems analogous
to the example of a non-executable "cat" that is reported if no
other cat exists but does not prevent /bin/cat from being run.
next prev parent reply other threads:[~2012-03-28 18:40 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 23:48 Bug? Bad permissions in $PATH breaks Git aliases James Pickens
2012-03-27 3:19 ` Jeff King
2012-03-27 7:25 ` James Pickens
2012-03-27 15:11 ` Junio C Hamano
2012-03-27 17:59 ` Jeff King
2012-03-27 18:04 ` [PATCH 1/2] run-command: propagate EACCES errors to parent Jeff King
2012-03-27 18:24 ` Junio C Hamano
2012-03-27 18:33 ` Jeff King
2012-03-27 18:05 ` [PATCH 2/2] git: continue alias lookup on EACCES errors Jeff King
2012-03-27 19:16 ` Junio C Hamano
2012-03-28 4:30 ` Jeff King
2012-03-28 17:42 ` Junio C Hamano
2012-03-28 17:48 ` Jeff King
2012-03-28 18:04 ` Jonathan Nieder
2012-03-28 18:31 ` Junio C Hamano
2012-03-28 18:40 ` Jonathan Nieder [this message]
2012-03-28 19:39 ` Jeff King
2012-03-28 19:45 ` Jonathan Nieder
2012-03-28 20:18 ` Jeff King
2012-03-28 20:37 ` Jeff King
2012-03-28 20:51 ` Jonathan Nieder
2012-03-28 20:52 ` Jeff King
2012-03-28 20:42 ` Jonathan Nieder
2012-03-28 20:51 ` Jeff King
2012-03-28 21:01 ` Jonathan Nieder
2012-03-28 21:25 ` Jeff King
2012-03-28 21:30 ` Frans Klaver
2012-03-28 20:43 ` Junio C Hamano
2012-03-28 21:04 ` Jeff King
2012-03-28 21:44 ` Junio C Hamano
2012-03-28 21:57 ` Jeff King
2012-03-28 22:07 ` Jeff King
2012-03-28 22:18 ` Junio C Hamano
2012-03-29 11:31 ` Frans Klaver
2012-03-29 17:20 ` Jeff King
2012-03-29 17:23 ` Frans Klaver
2012-03-28 19:38 ` Jeff King
2012-03-28 18:29 ` Junio C Hamano
2012-03-28 19:40 ` Jeff King
2012-03-29 11:16 ` Frans Klaver
2012-03-29 17:15 ` Jeff King
2012-03-29 17:21 ` Frans Klaver
2012-03-27 6:14 ` Bug? Bad permissions in $PATH breaks Git aliases Johannes Sixt
2012-03-27 7:37 ` James Pickens
2012-03-27 15:14 ` Junio C Hamano
2012-03-27 17:48 ` James Pickens
2012-03-27 18:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328184014.GA8982@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jepicken@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.