From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCy4P-0003Ve-Ss for qemu-devel@nongnu.org; Wed, 28 Mar 2012 14:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCy4N-0006jL-Tl for qemu-devel@nongnu.org; Wed, 28 Mar 2012 14:58:09 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:30113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCy4N-0006jA-N7 for qemu-devel@nongnu.org; Wed, 28 Mar 2012 14:58:07 -0400 Date: Wed, 28 Mar 2012 14:53:25 -0400 From: Konrad Rzeszutek Wilk Message-ID: <20120328185325.GC23805@phenom.dumpdata.com> References: <1332934907-24080-1-git-send-email-anthony.perard@citrix.com> <1332934907-24080-2-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1332934907-24080-2-git-send-email-anthony.perard@citrix.com> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH V10 1/8] pci_ids: Add INTEL_82599_SFP_VF id. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Xen Devel , QEMU-devel , Stefano Stabellini , "Michael S . Tsirkin" On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote: You really should say why this is added.. It is so odd just to have 'add this' without any justification. Can you at least say: "We are using this in our quirk lookup provided by patch titled: XXXYYY" ? > Signed-off-by: Anthony PERARD > Acked-by: Stefano Stabellini > --- > hw/pci_ids.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h > index e8235a7..649e6b3 100644 > --- a/hw/pci_ids.h > +++ b/hw/pci_ids.h > @@ -118,6 +118,7 @@ > #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 > #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a > #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c > +#define PCI_DEVICE_ID_INTEL_82599_SFP_VF 0x10ed > > #define PCI_VENDOR_ID_XEN 0x5853 > #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001 > -- > Anthony PERARD > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH V10 1/8] pci_ids: Add INTEL_82599_SFP_VF id. Date: Wed, 28 Mar 2012 14:53:25 -0400 Message-ID: <20120328185325.GC23805@phenom.dumpdata.com> References: <1332934907-24080-1-git-send-email-anthony.perard@citrix.com> <1332934907-24080-2-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1332934907-24080-2-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Anthony PERARD Cc: Xen Devel , QEMU-devel , Stefano Stabellini , "Michael S . Tsirkin" List-Id: xen-devel@lists.xenproject.org On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote: You really should say why this is added.. It is so odd just to have 'add this' without any justification. Can you at least say: "We are using this in our quirk lookup provided by patch titled: XXXYYY" ? > Signed-off-by: Anthony PERARD > Acked-by: Stefano Stabellini > --- > hw/pci_ids.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/pci_ids.h b/hw/pci_ids.h > index e8235a7..649e6b3 100644 > --- a/hw/pci_ids.h > +++ b/hw/pci_ids.h > @@ -118,6 +118,7 @@ > #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 > #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a > #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c > +#define PCI_DEVICE_ID_INTEL_82599_SFP_VF 0x10ed > > #define PCI_VENDOR_ID_XEN 0x5853 > #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001 > -- > Anthony PERARD > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel