From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD2ct-0004qG-4U for qemu-devel@nongnu.org; Wed, 28 Mar 2012 19:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD09v-0005oD-TM for qemu-devel@nongnu.org; Wed, 28 Mar 2012 17:12:01 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:47218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD09v-0005nZ-Jn for qemu-devel@nongnu.org; Wed, 28 Mar 2012 17:11:59 -0400 Date: Wed, 28 Mar 2012 17:07:20 -0400 From: Konrad Rzeszutek Wilk Message-ID: <20120328210719.GB2927@phenom.dumpdata.com> References: <1332934907-24080-1-git-send-email-anthony.perard@citrix.com> <1332934907-24080-3-git-send-email-anthony.perard@citrix.com> <20120328185224.GB23805@phenom.dumpdata.com> <4F737C4C.80706@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F737C4C.80706@us.ibm.com> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony PERARD , Xen Devel , QEMU-devel , Stefano Stabellini On Wed, Mar 28, 2012 at 04:02:04PM -0500, Anthony Liguori wrote: > On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote: > >On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: > >>Signed-off-by: Anthony PERARD > >>Acked-by: Stefano Stabellini > > > > > >Reviewed-by: me. > > FYI, the scripts that I use to manage patches will collect > Reviewed-by's and put them in the commit message so there's a proper > review history in git. > > But 'Reviewed-by: me.' will lose it's context and your review will > be forever lost to git history :-) I figured that Anthony would repost the patch set and stick my proper name in it... > > So please use the proper tags. > > Regards, > > Anthony Liguori > > > > >>--- > >> configure | 25 +++++++++++++++++++++++++ > >> 1 files changed, 25 insertions(+), 0 deletions(-) > >> > >>diff --git a/configure b/configure > >>index 14ef738..cb7bc75 100755 > >>--- a/configure > >>+++ b/configure > >>@@ -136,6 +136,7 @@ vnc_png="" > >> vnc_thread="no" > >> xen="" > >> xen_ctrl_version="" > >>+xen_pci_passthrough="" > >> linux_aio="" > >> cap_ng="" > >> attr="" > >>@@ -682,6 +683,10 @@ for opt do > >> ;; > >> --enable-xen) xen="yes" > >> ;; > >>+ --disable-xen-pci-passthrough) xen_pci_passthrough="no" > >>+ ;; > >>+ --enable-xen-pci-passthrough) xen_pci_passthrough="yes" > >>+ ;; > >> --disable-brlapi) brlapi="no" > >> ;; > >> --enable-brlapi) brlapi="yes" > >>@@ -1034,6 +1039,8 @@ echo " (affects only QEMU, not qemu-img)" > >> echo " --enable-mixemu enable mixer emulation" > >> echo " --disable-xen disable xen backend driver support" > >> echo " --enable-xen enable xen backend driver support" > >>+echo " --disable-xen-pci-passthrough" > >>+echo " --enable-xen-pci-passthrough" > >> echo " --disable-brlapi disable BrlAPI" > >> echo " --enable-brlapi enable BrlAPI" > >> echo " --disable-vnc-tls disable TLS encryption for VNC server" > >>@@ -1478,6 +1485,21 @@ EOF > >> fi > >> fi > >> > >>+if test "$xen_pci_passthrough" != "no"; then > >>+ if test "$xen" = "yes"&& test "$linux" = "yes"; then > >>+ xen_pci_passthrough=yes > >>+ else > >>+ if test "$xen_pci_passthrough" = "yes"; then > >>+ echo "ERROR" > >>+ echo "ERROR: User requested feature Xen PCI Passthrough" > >>+ echo "ERROR: but this feature require /sys from Linux" > >>+ echo "ERROR" > >>+ exit 1; > >>+ fi > >>+ xen_pci_passthrough=no > >>+ fi > >>+fi > >>+ > >> ########################################## > >> # pkg-config probe > >> > >>@@ -3635,6 +3657,9 @@ case "$target_arch2" in > >> if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then > >> target_phys_bits=64 > >> echo "CONFIG_XEN=y">> $config_target_mak > >>+ if test "$xen_pci_passthrough" = yes; then > >>+ echo "CONFIG_XEN_PCI_PASSTHROUGH=y">> "$config_target_mak" > >>+ fi > >> else > >> echo "CONFIG_NO_XEN=y">> $config_target_mak > >> fi > >>-- > >>Anthony PERARD > >> > >> > >>_______________________________________________ > >>Xen-devel mailing list > >>Xen-devel@lists.xen.org > >>http://lists.xen.org/xen-devel > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough. Date: Wed, 28 Mar 2012 17:07:20 -0400 Message-ID: <20120328210719.GB2927@phenom.dumpdata.com> References: <1332934907-24080-1-git-send-email-anthony.perard@citrix.com> <1332934907-24080-3-git-send-email-anthony.perard@citrix.com> <20120328185224.GB23805@phenom.dumpdata.com> <4F737C4C.80706@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F737C4C.80706@us.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Anthony Liguori Cc: Anthony PERARD , Xen Devel , QEMU-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, Mar 28, 2012 at 04:02:04PM -0500, Anthony Liguori wrote: > On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote: > >On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: > >>Signed-off-by: Anthony PERARD > >>Acked-by: Stefano Stabellini > > > > > >Reviewed-by: me. > > FYI, the scripts that I use to manage patches will collect > Reviewed-by's and put them in the commit message so there's a proper > review history in git. > > But 'Reviewed-by: me.' will lose it's context and your review will > be forever lost to git history :-) I figured that Anthony would repost the patch set and stick my proper name in it... > > So please use the proper tags. > > Regards, > > Anthony Liguori > > > > >>--- > >> configure | 25 +++++++++++++++++++++++++ > >> 1 files changed, 25 insertions(+), 0 deletions(-) > >> > >>diff --git a/configure b/configure > >>index 14ef738..cb7bc75 100755 > >>--- a/configure > >>+++ b/configure > >>@@ -136,6 +136,7 @@ vnc_png="" > >> vnc_thread="no" > >> xen="" > >> xen_ctrl_version="" > >>+xen_pci_passthrough="" > >> linux_aio="" > >> cap_ng="" > >> attr="" > >>@@ -682,6 +683,10 @@ for opt do > >> ;; > >> --enable-xen) xen="yes" > >> ;; > >>+ --disable-xen-pci-passthrough) xen_pci_passthrough="no" > >>+ ;; > >>+ --enable-xen-pci-passthrough) xen_pci_passthrough="yes" > >>+ ;; > >> --disable-brlapi) brlapi="no" > >> ;; > >> --enable-brlapi) brlapi="yes" > >>@@ -1034,6 +1039,8 @@ echo " (affects only QEMU, not qemu-img)" > >> echo " --enable-mixemu enable mixer emulation" > >> echo " --disable-xen disable xen backend driver support" > >> echo " --enable-xen enable xen backend driver support" > >>+echo " --disable-xen-pci-passthrough" > >>+echo " --enable-xen-pci-passthrough" > >> echo " --disable-brlapi disable BrlAPI" > >> echo " --enable-brlapi enable BrlAPI" > >> echo " --disable-vnc-tls disable TLS encryption for VNC server" > >>@@ -1478,6 +1485,21 @@ EOF > >> fi > >> fi > >> > >>+if test "$xen_pci_passthrough" != "no"; then > >>+ if test "$xen" = "yes"&& test "$linux" = "yes"; then > >>+ xen_pci_passthrough=yes > >>+ else > >>+ if test "$xen_pci_passthrough" = "yes"; then > >>+ echo "ERROR" > >>+ echo "ERROR: User requested feature Xen PCI Passthrough" > >>+ echo "ERROR: but this feature require /sys from Linux" > >>+ echo "ERROR" > >>+ exit 1; > >>+ fi > >>+ xen_pci_passthrough=no > >>+ fi > >>+fi > >>+ > >> ########################################## > >> # pkg-config probe > >> > >>@@ -3635,6 +3657,9 @@ case "$target_arch2" in > >> if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then > >> target_phys_bits=64 > >> echo "CONFIG_XEN=y">> $config_target_mak > >>+ if test "$xen_pci_passthrough" = yes; then > >>+ echo "CONFIG_XEN_PCI_PASSTHROUGH=y">> "$config_target_mak" > >>+ fi > >> else > >> echo "CONFIG_NO_XEN=y">> $config_target_mak > >> fi > >>-- > >>Anthony PERARD > >> > >> > >>_______________________________________________ > >>Xen-devel mailing list > >>Xen-devel@lists.xen.org > >>http://lists.xen.org/xen-devel > >