From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org, Zeng Zhaoming <zengzm.kernel@gmail.com>
Subject: Re: [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up
Date: Thu, 29 Mar 2012 12:16:05 +0100 [thread overview]
Message-ID: <20120329111605.GK3668@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1333000305-27280-1-git-send-email-shawn.guo@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]
On Thu, Mar 29, 2012 at 01:51:45PM +0800, Shawn Guo wrote:
> + SND_SOC_DAPM_ADC_E("ADC", "Capture", SGTL5000_CHIP_ANA_POWER, 1, 0,
> + power_vag_event,
> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
> + SND_SOC_DAPM_DAC_E("DAC", "Playback", SGTL5000_CHIP_ANA_POWER, 3, 0,
> + power_vag_event,
> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
What would be more idiomatic here would be to make VAG a supply widget
and then connect it to DAC and ADC rather than have the event on both -
It looks like with your current code simultaneous playback and capture
will break, you'll run through the power sequences twice and if you stop
one stream it'll power down the other.
> + {"Mic Bias", NULL, "MIC_IN"}, /* mic_in --> mic bias */
> + {"Capture Mux", "MIC_IN", "Mic Bias"}, /* mic bias --> adc_mux */
This should be in the machine driver.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-03-29 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 5:51 [PATCH] ASoC: sgtl5000: Enable VAG when DAC/ADC up Shawn Guo
[not found] ` <20120329071700.GA18127@zzm-ubuntu>
2012-03-29 10:58 ` Mark Brown
2012-03-29 14:04 ` Shawn Guo
2012-03-29 14:10 ` Mark Brown
2012-03-29 14:19 ` Shawn Guo
2012-04-25 2:08 ` Richard Zhao
2012-04-25 8:11 ` Mark Brown
2012-03-29 11:16 ` Mark Brown [this message]
2012-03-29 11:24 ` Dong Aisheng-B29396
[not found] ` <20120329120933.GA27740@zzm-ubuntu>
2012-03-29 12:11 ` Mark Brown
2012-03-29 13:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329111605.GK3668@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=shawn.guo@linaro.org \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.