From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx136.postini.com [74.125.245.136]) by kanga.kvack.org (Postfix) with SMTP id 8EF8B6B0044 for ; Thu, 29 Mar 2012 10:10:39 -0400 (EDT) Date: Thu, 29 Mar 2012 22:05:25 +0800 From: Fengguang Wu Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name Message-ID: <20120329140525.GA10452@localhost> References: <1332843450-7100-1-git-send-email-bp@amd64.org> <20120328090909.GX22197@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120328090909.GX22197@one.firstfloor.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: David Rientjes , Borislav Petkov , LKML , Borislav Petkov , linux-mm@kvack.org, Andrew Morton On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote: > > I agree with your change, but I'm not sure these should be pr_info() to > > start with, these seem more like debugging messages? I can't see how > > they'd be useful in standard operation so could we just convert them to be > > debug instead? > > Well it tells why the page recovery didn't work. > > Memory recovery is a somewhat obscure path, so it's better to have > full information. Nod, and it won't disturb the users unless something really bad happens. I'm fine with the patch, too. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759415Ab2C2OKq (ORCPT ); Thu, 29 Mar 2012 10:10:46 -0400 Received: from mga14.intel.com ([143.182.124.37]:53456 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408Ab2C2OKi (ORCPT ); Thu, 29 Mar 2012 10:10:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="124815437" Date: Thu, 29 Mar 2012 22:05:25 +0800 From: Fengguang Wu To: Andi Kleen Cc: David Rientjes , Borislav Petkov , LKML , Borislav Petkov , linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH] mm/memory_failure: Let the compiler add the function name Message-ID: <20120329140525.GA10452@localhost> References: <1332843450-7100-1-git-send-email-bp@amd64.org> <20120328090909.GX22197@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120328090909.GX22197@one.firstfloor.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 28, 2012 at 11:09:09AM +0200, Andi Kleen wrote: > > I agree with your change, but I'm not sure these should be pr_info() to > > start with, these seem more like debugging messages? I can't see how > > they'd be useful in standard operation so could we just convert them to be > > debug instead? > > Well it tells why the page recovery didn't work. > > Memory recovery is a somewhat obscure path, so it's better to have > full information. Nod, and it won't disturb the users unless something really bad happens. I'm fine with the patch, too. Thanks, Fengguang