From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Thu, 29 Mar 2012 08:20:30 -0700 From: Greg KH To: Rusty Russell Cc: Sasha Levin , Tim Abbott , stable@vger.kernel.org Subject: Re: Patch Upstream: module: Remove module size limit Message-ID: <20120329152030.GA6986@kroah.com> References: <20120328220121.108CF26EF@git.kroah.org> <20120328224112.GA10691@kroah.com> <20120328230952.GA6419@kroah.com> <20120328233252.GA16375@kroah.com> <877gy4ypjb.fsf@rustcorp.com.au> MIME-Version: 1.0 In-Reply-To: <877gy4ypjb.fsf@rustcorp.com.au> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit List-ID: On Thu, Mar 29, 2012 at 03:25:20PM +1030, Rusty Russell wrote: > On Wed, 28 Mar 2012 16:32:52 -0700, Greg KH wrote: > > On Thu, Mar 29, 2012 at 01:22:23AM +0200, Sasha Levin wrote: > > > On Thu, Mar 29, 2012 at 1:09 AM, Greg KH wrote: > > > > On Thu, Mar 29, 2012 at 12:57:47AM +0200, Sasha Levin wrote: > > > >> On Thu, Mar 29, 2012 at 12:41 AM, Greg KH wrote: > > > >> > For the patch below, what are the "real world use cases" that would > > > >> > cause this to be needed in the stable kernel trees? �Is there an > > > >> > in-kernel module that is affected by this limitation? > > > >> > > > >> There are no in-kernel modules which are affected, the "real world" > > > >> scenario is debug modules generated by Ksplice. > > > > > > > > So why is this needed for the stable kernels? �This really looks like a > > > > feature not a bugfix to me, how about you? > > > > > > I guess it depends on whether you consider the inability to load > > > modules bigger than 64mb as a bug or not. > > > > As there is no in-kernel user with this problem, no, I don't think it's > > a bug that meets the rules documented in > > Documentation/stable_kernel_rules.txt, do you? > > Your call, but it has been my policy to support ksplice, such as making > sure we export symbols it needs. And this really is a low-risk change. Ok, but note, it really would be good if we could get the ksplice code into the kernel tree, I hate supporting out-of-tree modules... thanks, greg k-h