From: Sam Ravnborg <sam@ravnborg.org>
To: Alessio Igor Bogani <abogani@kernel.org>
Cc: Frank Rowand <frank.rowand@am.sony.com>,
Rowand Frank <Frank_Rowand@sonyusa.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Jan Beulich <jbeulich@novell.com>,
Kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Tim Bird <Tim.Bird@am.sony.com>,
Anders Kaseorg <andersk@ksplice.com>,
Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH] Let modpost parses vmlinux instead of vmlinux.o
Date: Thu, 29 Mar 2012 22:23:45 +0200 [thread overview]
Message-ID: <20120329202345.GA30158@merkur.ravnborg.org> (raw)
In-Reply-To: <1333032786-12457-1-git-send-email-abogani@kernel.org>
On Thu, Mar 29, 2012 at 04:53:06PM +0200, Alessio Igor Bogani wrote:
> Dear Mr. Rowand,
>
> What do you think about this patch?
> Thanks!
>
> Ciao,
> Alessio
Hi Alession.
I am not Mr. Rowand - obviously...
The title alone looks like you are doing something wrong.
The difference between vmlinux.o and vmlinux is that the latter
is linked using the linker scripts. So a lot of sections are merged.
And modpost uses these section for the section mismatch analysis.
Then your patch fails to describe why it is needed.
And on top of this I do not understand the patch.
So a lot of things looks bad :-(
Sam
>
> ---
> Makefile | 2 +-
> scripts/Makefile.modpost | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 123d858..b589d1f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -876,7 +876,7 @@ quiet_cmd_vmlinux-modpost = LD $@
> define rule_vmlinux-modpost
> :
> +$(call cmd,vmlinux-modpost)
> - $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $@
> + $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost $*
I do not see where the stem is coming from - and why this is needed.
> $(Q)echo 'cmd_$@ := $(cmd_vmlinux-modpost)' > $(dot-target).cmd
> endef
>
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 56dfafc..ca0db29 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -93,7 +93,7 @@ __modpost: $(modules:.ko=.o) FORCE
> quiet_cmd_kernel-mod = MODPOST $@
> cmd_kernel-mod = $(modpost) $@
>
> -vmlinux.o: FORCE
> +vmlinux vmlinux.o: FORCE
> $(call cmd,kernel-mod)
It looks like you process both of vmlinux.o and vmlinux?!?!
next prev parent reply other threads:[~2012-03-29 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F737193.4030709@am.sony.com>
2012-03-29 14:53 ` [PATCH] Let modpost parses vmlinux instead of vmlinux.o Alessio Igor Bogani
2012-03-29 20:23 ` Sam Ravnborg [this message]
2012-03-29 21:53 ` Frank Rowand
2012-03-29 21:57 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329202345.GA30158@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Frank_Rowand@sonyusa.com \
--cc=Tim.Bird@am.sony.com \
--cc=abogani@kernel.org \
--cc=andersk@ksplice.com \
--cc=frank.rowand@am.sony.com \
--cc=jbeulich@novell.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.