From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix buffer lookup race on allocation failure
Date: Fri, 30 Mar 2012 08:04:49 +1100 [thread overview]
Message-ID: <20120329210449.GB692@dastard> (raw)
In-Reply-To: <20120329190759.GA8622@infradead.org>
On Thu, Mar 29, 2012 at 03:07:59PM -0400, Christoph Hellwig wrote:
> I don't like this solution. What speaks against building up the page
> array after the first buffer lookup failed, but before linking the
> buffer into the rbtree? That's the the inode cache and all the VFS
> caches do.
That could be done, I think. I always wondered why it was done after
insert, but never knew the reason so I didn't change the logic. I'll
respin it and see what happens.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-03-29 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 12:07 [PATCH] xfs: fix buffer lookup race on allocation failure Dave Chinner
2012-03-29 16:53 ` Mark Tinguely
2012-03-29 19:07 ` Christoph Hellwig
2012-03-29 21:04 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329210449.GB692@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.