Re: [PATCH 03/15] perf: Unified API to record selective sets of arch registers

[Jiri Olsa <jolsa@redhat.com>]

On Fri, Mar 30, 2012 at 04:51:58PM +0400, Cyrill Gorcunov wrote:
> On Wed, Mar 28, 2012 at 02:35:46PM +0200, Jiri Olsa wrote:
> ...
> > +static inline u64 perf_reg_value(struct pt_regs *regs, int idx)
> > +{
> > +	switch (idx) {
> > +	case PERF_X86_64_REG_RAX:
> > +		return regs->ax;
> > +	case PERF_X86_64_REG_RBX:
> > +		return regs->bx;
> > +	case PERF_X86_64_REG_RCX:
> > +		return regs->cx;
> > +	case PERF_X86_64_REG_RDX:
> > +		return regs->dx;
> > +	case PERF_X86_64_REG_RSI:
> > +		return regs->si;
> > +	case PERF_X86_64_REG_RDI:
> > +		return regs->di;
> > +	case PERF_X86_64_REG_R8:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R9:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R10:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R11:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R12:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R13:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R14:
> > +		return regs->r8;
> > +	case PERF_X86_64_REG_R15:
> > +		return regs->r8;
> 
> I guess there are too much r8's :-)
> 
> 	Cyrill

yay :)) right, one should be enough..

thanks,
jirka