From: Greg KH <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Sasha Levin <levinsasha928@gmail.com>,
viro@zeniv.linux.org.uk, davej@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmsg: Use vmalloc instead of kmalloc when writing
Date: Fri, 30 Mar 2012 14:17:44 -0700 [thread overview]
Message-ID: <20120330211744.GA16314@kroah.com> (raw)
In-Reply-To: <201203302105.52987.arnd@arndb.de>
On Fri, Mar 30, 2012 at 09:05:52PM +0000, Arnd Bergmann wrote:
> On Friday 30 March 2012, Thomas Gleixner wrote:
> > I think so. This is an interface to inject stuff into dmesg. Limiting
> > that to a reasonable size makes sense. We can probably limit it to
> > something small like 1024, but I don't know about the "ideas" of those
> > folks who think that it's a great idea to do it at all.
>
> I guess a page would be a reasonable size, similar to what we do for
> sysfs.
Ok. Sasha, as you seem to have noticed this, care to dig in syslog and
systemd to get an idea of the buffer sizes they are expecting to pass
into kmsg, and if they can handle a short write properly? If so,
restricting it to a page is fine with me, otherwise we might want to
make it a bit bigger.
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-30 21:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 17:04 [PATCH] kmsg: Use vmalloc instead of kmalloc when writing Sasha Levin
2012-03-30 15:30 ` Greg KH
2012-03-30 16:37 ` Sasha Levin
2012-03-30 16:49 ` Greg KH
2012-03-30 17:15 ` Sasha Levin
2012-03-30 20:35 ` Thomas Gleixner
2012-03-30 20:42 ` Greg KH
2012-03-30 20:49 ` Thomas Gleixner
2012-03-30 21:05 ` Arnd Bergmann
2012-03-30 21:17 ` Greg KH [this message]
2012-03-30 22:02 ` Sasha Levin
2012-03-30 23:43 ` Greg KH
2012-03-31 0:02 ` Kay Sievers
2012-03-31 8:57 ` Sasha Levin
2012-04-23 9:54 ` Sasha Levin
2012-03-30 21:18 ` Thomas Gleixner
2012-03-31 1:43 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120330211744.GA16314@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.