All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, David Smith <dsmith@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Steven Rostedt <rostedt@goodmis.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix the "old_pid" usage in trace_sched_process_exec()
Date: Sat, 31 Mar 2012 11:52:02 +0200	[thread overview]
Message-ID: <20120331095158.GA887@gmail.com> (raw)
In-Reply-To: <20120330162930.GA4902@redhat.com>


* Oleg Nesterov <oleg@redhat.com> wrote:

> On 03/30, Oleg Nesterov wrote:
> >
> > 1. TRACE_EVENT(sched_process_exec) forgets to actually use the
> >    old pid argument, it sets ->old_pid = p->pid.
> >
> > 2. search_binary_handler() uses the wrong pid number. tracepoint
> >    needs the global pid_t from the root namespace, while old_pid
> >    is the virtual pid number as it seen by the tracer/parent.
> 
> Not really serious, but probably makes sense for 3.4. This fixes
> the recently merged 4ff16c25e2cc48cbe6956e356c38a25ac063a64d
> "tracepoint, vfs, sched: Add exec() tracepoint"

Thanks Oleg - will queue your fix up in tip:perf/urgent.

Thanks,

	Ingo

  reply	other threads:[~2012-03-31  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 16:26 [PATCH] tracing: fix the "old_pid" usage in trace_sched_process_exec() Oleg Nesterov
2012-03-30 16:29 ` Oleg Nesterov
2012-03-31  9:52   ` Ingo Molnar [this message]
2012-03-31 17:20 ` [tip:perf/urgent] tracing, sched, vfs: Fix 'old_pid' " tip-bot for Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120331095158.GA887@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dsmith@redhat.com \
    --cc=dvlasenk@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.