From: Olaf Hering <olaf@aepfle.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386
Date: Sat, 31 Mar 2012 18:46:27 +0200 [thread overview]
Message-ID: <20120331164627.GA23873@aepfle.de> (raw)
In-Reply-To: <4F772590.2000603@suse.de>
On Sat, Mar 31, Andreas Färber wrote:
> This is the only usage of += outside Makefile fragments, so I wonder if
> its use may have been by accident. Is it safe in a POSIX context?
> Or should we better use CFLAGS="$CFLAGS -march=486"?
Now that I look at the shebang, configure is a sh script and += is most
likely a bash feature. So your suggestion for the assignment is correct.
Olaf
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu/configure: fix CFLAGS handling for i386
Date: Sat, 31 Mar 2012 18:46:27 +0200 [thread overview]
Message-ID: <20120331164627.GA23873@aepfle.de> (raw)
In-Reply-To: <4F772590.2000603@suse.de>
On Sat, Mar 31, Andreas Färber wrote:
> This is the only usage of += outside Makefile fragments, so I wonder if
> its use may have been by accident. Is it safe in a POSIX context?
> Or should we better use CFLAGS="$CFLAGS -march=486"?
Now that I look at the shebang, configure is a sh script and += is most
likely a bash feature. So your suggestion for the assignment is correct.
Olaf
next prev parent reply other threads:[~2012-03-31 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 15:24 [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386 Olaf Hering
2012-03-30 15:24 ` Olaf Hering
2012-03-31 15:41 ` [Qemu-devel] " Andreas Färber
2012-03-31 15:41 ` Andreas Färber
2012-03-31 16:46 ` Olaf Hering [this message]
2012-03-31 16:46 ` Olaf Hering
2012-04-02 7:54 ` [Qemu-devel] " Andreas Färber
2012-04-02 7:54 ` Andreas Färber
2012-03-31 16:52 ` [Qemu-devel] " Peter Maydell
2012-03-31 16:52 ` Peter Maydell
2012-03-31 16:55 ` [Qemu-devel] " Olaf Hering
2012-03-31 16:55 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331164627.GA23873@aepfle.de \
--to=olaf@aepfle.de \
--cc=afaerber@suse.de \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.