From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: On patch "Remove all #inclusions of asm/system.h"
Date: Sat, 31 Mar 2012 22:44:52 +0200 [thread overview]
Message-ID: <20120331224452.1862a2b4@stein> (raw)
In-Reply-To: <31597.1333222293@redhat.com>
On Mar 31 David Howells wrote:
> Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> > For example, drivers/firewire/{core-device,core-topology,ohci,sbp2}.c use
> > smp_rmb()¹ and used to include asm/system.h. Now they do not include
> > asm/barrier.h. Is this by mistake or on purpose?
>
> I tried to make sure allyesconfig worked for x86_64 and a bunch of defconfigs
> worked. I can't guarantee that that got 100% coverage. I also knew there
> would be some breakage from the base Linux kernel having moved on by the time
> Linus pulled myu patches - though I don't know if this is the case here (I
> suspect not).
It's not a problem; they now get barrier.h via spinlock.h. I just
wondered whether absence of #include <asm/barrier.h> in those files had a
deeper non-obvious meaning. Since it doesn't I will just put that include
in them next time around when I do some housekeeping there.
--
Stefan Richter
-=====-===-- --== =====
http://arcgraph.de/sr/
next prev parent reply other threads:[~2012-03-31 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 13:34 On patch "Remove all #inclusions of asm/system.h" Stefan Richter
2012-03-31 19:31 ` David Howells
2012-03-31 20:44 ` Stefan Richter [this message]
2012-04-01 1:46 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331224452.1862a2b4@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.