Re: [PATCH 14/17] ASoC: tegra: add tegra30-ahub driver

[Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On Sat, Mar 31, 2012 at 08:04:58PM -0600, Stephen Warren wrote:
> On 03/31/2012 02:14 PM, Mark Brown wrote:

> > This looks like a fairly clear sign that this should be a CODEC driver,

> My aim here was to get something basic in place before I looked into all
> the "SoC DSP" and separate FE/BE stuuf, and how to express the AHUB and
> DAS as codecs.

The DAS might be more suited to the soc-pcm model given that there's
more of a tight coupling between what goes in and what comes out (from
what I remember).

> > or possibly the DMA driver - if nothing else even if you didn't change
> > anything else about the implementation it'd ensure that you didn't need
> > to open code this probe checking.

> Maybe just because I haven't looked into this at all, but I'm not sure
> how this would solve the probing issue; I can see that the machine
> driver wouldn't (ASoC rather than pdev) probe until the AHUB driver had
> (pdev) probed, but how would that affect the dependent device probes? I
> suppose it'd work out if the dependent devices didn't touch HW until
> their ASoC probes?

Yes, exactly - allocate the resources in the platform driver probes,
register with ASoC and then only touch the hardware when ASoC tells you
the whole card is ready.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]