From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c Date: Tue, 3 Apr 2012 11:07:48 +0200 Message-ID: <20120403090748.GA27810@aepfle.de> References: <1092e073b88e0aed775e.1333095927@probook.site> <20345.45252.747454.411523@mariner.uk.xensource.com> <20120402195425.GA21392@aepfle.de> <1333441383.25602.105.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1333441383.25602.105.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Tue, Apr 03, Ian Campbell wrote: > On Mon, 2012-04-02 at 20:54 +0100, Olaf Hering wrote: > > On Mon, Apr 02, Ian Jackson wrote: > > > > > Olaf Hering writes ("[Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c"): > > > > node-select.c: In function 'vchan_wr': > > > > node-select.c:60:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] > > > > > > This one is a question of coding style. Apparently libvchan uses > > > mixed statements/declarations, so this should be fixed by changing the > > > warning flags. > However skimming over node-select.c and io.c (as another random file) it > looks like the use of mixed declarations and code is the exception not > the rule even within libvchan, so I think it would be fine to fix the > two places where this isn't the case. If thats ok with IanJ as well, I will prepare another patch to fix just that warning in node-select.c Olaf