From: Stephen Hemminger <shemminger@vyatta.com>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] marvell sky2 driver: fix so it works without unaligned accesses
Date: Tue, 3 Apr 2012 09:17:50 -0700 [thread overview]
Message-ID: <20120403091750.11eff45b@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <201204031527.q33FR04i031747@farm-0027.internal.tilera.com>
On Tue, 3 Apr 2012 11:13:56 -0400
Chris Metcalf <cmetcalf@tilera.com> wrote:
> The driver uses a receive_new() routine that ends up requiring unaligned
> accesses in IP header processing. If the architecture doesn't support
> efficient unaligned accesses, just copy all ingress packets to the bounce
> buffers instead.
>
> This allows the driver to be used on the Tilera TILEmpower-Gx, since
> the tile architecture doesn't currently handle kernel unaligned accesses,
> just userspace.
>
> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
There are many other encapsulation cases where IP header won't be
aligned. Why not just set copybreak module option to a very large value?
next prev parent reply other threads:[~2012-04-03 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 15:13 [PATCH] marvell sky2 driver: fix so it works without unaligned accesses Chris Metcalf
2012-04-03 16:17 ` Stephen Hemminger [this message]
2012-04-03 16:18 ` Eric Dumazet
2012-04-03 21:46 ` David Miller
2012-04-04 14:13 ` [PATCH v2] " Chris Metcalf
2012-04-04 16:04 ` Stephen Hemminger
2012-04-04 18:42 ` Stephen Hemminger
2012-04-04 21:52 ` Chris Metcalf
2012-04-04 22:10 ` [PATCH v3] sky2: copy received packets on inefficient unaligned architecture Stephen Hemminger
2012-04-04 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403091750.11eff45b@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.