From: Stephen Hemminger <shemminger@vyatta.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi()
Date: Tue, 3 Apr 2012 11:55:47 -0700 [thread overview]
Message-ID: <20120403115547.799fcc1f@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <20120330173616.GC2703@Neptun>
On Fri, 30 Mar 2012 19:36:16 +0200
Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
> In sky2_test_msi() the temporarily set SW IRQ in B0 register is not reset in case
> that request_irq() fails.
> With this patch we only set the interrupt mask if request_irq() was successful.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Ok, but this is a non-serious error case. If request_irq() fails here,
the driver is going to fail to load and on the failure path of
sky2_probe will reset the chip on the way out.
next prev parent reply other threads:[~2012-04-03 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 17:36 [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() Lino Sanfilippo
2012-04-01 20:11 ` David Miller
2012-04-03 18:55 ` Stephen Hemminger [this message]
2012-04-03 20:09 ` Lino Sanfilippo
2012-04-03 20:30 ` David Miller
2012-04-03 20:59 ` Stephen Hemminger
2012-04-03 21:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403115547.799fcc1f@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=LinoSanfilippo@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.