From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] serial: PL011: move interrupt clearing Date: Tue, 3 Apr 2012 09:19:23 -0700 Message-ID: <20120403161923.GB4894@kroah.com> References: <1332357318-8017-1-git-send-email-linus.walleij@linaro.org> <20120329213333.GA15231@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:34656 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755220Ab2DCQT2 (ORCPT ); Tue, 3 Apr 2012 12:19:28 -0400 Received: by pbcun15 with SMTP id un15so60545pbc.19 for ; Tue, 03 Apr 2012 09:19:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Paul Gortmaker Cc: Grant Likely , Linus Walleij , linux-serial@vger.kernel.org, Russell King , Jong-Sung Kim , stable , Chanho Min , linux-arm-kernel@lists.infradead.org, Shreshtha Kumar Sahu On Tue, Apr 03, 2012 at 11:36:23AM -0400, Paul Gortmaker wrote: > On Thu, Mar 29, 2012 at 5:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Mar 29, 2012 at 02:49:37PM -0600, Grant Likely wrote: > >> On Wed, Mar 21, 2012 at 1:15 PM, Linus Walleij wrote: > >> > Commit 360f748b204275229f8398cb2f9f53955db1503b > >> > "serial: PL011: clear pending interrupts" > >> > attempts to clear interrupts by writing to a > >> > yet-unassigned memory address. This fixes the issue. > >> > > >> > The breaking patch is marked for stable so should be > >> > carried along with the other patch. > >> > > >> > Cc: Shreshtha Kumar Sahu > >> > Cc: Russell King > >> > Cc: stable > >> > Reported-by: Viresh Kumar > >> > Signed-off-by: Linus Walleij > >> > >> Ugh; the original patch is obviously broken. =A0How did it get app= lied > >> without testing? > >> > >> Greg, can you get this out to Linus ASAP please? =A0I have one com= ment > >> below, but I don't think it should block merging this patch. > >> > >> Tested-by: Grant Likely > > > > Thanks, I'll get it to him after 3.4-rc1 is out, in a few days, alo= ng > > with other tty fixes being queued up. >=20 > Hi Greg, >=20 > Just wanted to check this didn't fall through the cracks, as I don't > see it in your tty-next or tty-linus branches. >=20 > The original bad commit causes Silent Boot Death on qemu ARM > versatile, which is kind of nasty. It pretty much forces a bisection= , > which I did, which then led me here. It's still in my "to-apply" queue, don't worry, it's not lost. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 3 Apr 2012 09:19:23 -0700 Subject: [PATCH] serial: PL011: move interrupt clearing In-Reply-To: References: <1332357318-8017-1-git-send-email-linus.walleij@linaro.org> <20120329213333.GA15231@kroah.com> Message-ID: <20120403161923.GB4894@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 03, 2012 at 11:36:23AM -0400, Paul Gortmaker wrote: > On Thu, Mar 29, 2012 at 5:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Mar 29, 2012 at 02:49:37PM -0600, Grant Likely wrote: > >> On Wed, Mar 21, 2012 at 1:15 PM, Linus Walleij wrote: > >> > Commit 360f748b204275229f8398cb2f9f53955db1503b > >> > "serial: PL011: clear pending interrupts" > >> > attempts to clear interrupts by writing to a > >> > yet-unassigned memory address. This fixes the issue. > >> > > >> > The breaking patch is marked for stable so should be > >> > carried along with the other patch. > >> > > >> > Cc: Shreshtha Kumar Sahu > >> > Cc: Russell King > >> > Cc: stable > >> > Reported-by: Viresh Kumar > >> > Signed-off-by: Linus Walleij > >> > >> Ugh; the original patch is obviously broken. ?How did it get applied > >> without testing? > >> > >> Greg, can you get this out to Linus ASAP please? ?I have one comment > >> below, but I don't think it should block merging this patch. > >> > >> Tested-by: Grant Likely > > > > Thanks, I'll get it to him after 3.4-rc1 is out, in a few days, along > > with other tty fixes being queued up. > > Hi Greg, > > Just wanted to check this didn't fall through the cracks, as I don't > see it in your tty-next or tty-linus branches. > > The original bad commit causes Silent Boot Death on qemu ARM > versatile, which is kind of nasty. It pretty much forces a bisection, > which I did, which then led me here. It's still in my "to-apply" queue, don't worry, it's not lost. greg k-h