All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: David Sterba <dsterba@suse.cz>,
	Chris Mason <chris.mason@oracle.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-btrfs@vger.kernel.org, jeffm@suse.com
Subject: Re: btrfs io errors on 3.4rc1
Date: Tue, 3 Apr 2012 13:16:33 -0400	[thread overview]
Message-ID: <20120403171632.GA25334@redhat.com> (raw)
In-Reply-To: <20120403170750.GB10975@redhat.com>

On Tue, Apr 03, 2012 at 01:07:50PM -0400, Dave Jones wrote:

 >  > wait, what...
 >  > 
 >  >  535         memset(trans, 0, sizeof(*trans));
 >  >  536         kmem_cache_free(btrfs_trans_handle_cachep, trans);
 >  >  537 
 >  >  538         if (throttle)
 >  >  539                 btrfs_run_delayed_iputs(root);
 >  >  540 
 >  >  541         if (trans->aborted ||
 >  >  542             root->fs_info->fs_state & BTRFS_SUPER_FLAG_ERROR) {
 >  >  543                 return -EIO;
 >  >  544         }
 >  > 
 >  > that looks like a pretty clear use-after-free.
 > 
 > Ok, trying this..

Yep that fixes it.  Chris I'll mail it to you again with a proper sign-off.

thanks for the help chasing this down David.

	Dave
 

  reply	other threads:[~2012-04-03 17:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 18:02 btrfs io errors on 3.4rc1 Dave Jones
2012-04-02 19:48 ` Chris Mason
2012-04-02 21:16   ` Dave Jones
2012-04-02 21:26     ` Chris Mason
2012-04-02 21:40       ` Dave Jones
2012-04-02 22:28         ` Chris Mason
2012-04-02 22:33           ` Dave Jones
2012-04-02 22:39             ` Chris Mason
2012-04-02 22:51               ` Dave Jones
2012-04-02 23:50                 ` Chris Mason
2012-04-03  1:47                   ` Dave Jones
2012-04-03 14:26                     ` David Sterba
2012-04-03 16:20                       ` Dave Jones
2012-04-03 16:33                         ` David Sterba
2012-04-03 16:50                           ` Dave Jones
2012-04-03 17:07                             ` Dave Jones
2012-04-03 17:16                               ` Dave Jones [this message]
2012-04-03 17:24                                 ` David Sterba
2012-04-03 19:35                                 ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120403171632.GA25334@redhat.com \
    --to=davej@redhat.com \
    --cc=chris.mason@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=jeffm@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.